From c787b6a7a64e4436641245812756b8e77dc87d2b Mon Sep 17 00:00:00 2001 From: Aleksander Nowodzinski Date: Wed, 15 Mar 2017 12:53:09 +0100 Subject: [PATCH 1/2] Other: Introduced consistent height and spacing among headings dropdown items. Closes #63. --- theme/theme.scss | 11 +++++++++++ 1 file changed, 11 insertions(+) diff --git a/theme/theme.scss b/theme/theme.scss index 0b0f0fd..b367a74 100644 --- a/theme/theme.scss +++ b/theme/theme.scss @@ -1,6 +1,9 @@ // Copyright (c) 2003-2017, CKSource - Frederico Knabben. All rights reserved. // For licensing, see LICENSE.md or http://ckeditor.com/license +@import '~@ckeditor/ckeditor5-theme-lark/theme/helpers/_spacing'; +@import '~@ckeditor/ckeditor5-theme-lark/theme/helpers/_fonts'; + .ck-heading_heading { &1 { font-size: 1.5em; @@ -15,6 +18,14 @@ } } +// Using absolute units to make sure each element has the same height and padding. +// https://github.com/ckeditor/ckeditor5-heading/issues/63 +[class*="ck-heading_"] { + line-height: 1.8 * $ck-font-size-base; + // Strip the units from $ck-def-spacing here. + padding: $ck-def-spacing / ( $ck-def-spacing * 0 + 1 ) * $ck-font-size-base; +} + [class*="ck-heading_heading"] { font-weight: bold; } From 8bcb29b6e0b9511d43deadeddf916e7053a76aaa Mon Sep 17 00:00:00 2001 From: Aleksander Nowodzinski Date: Wed, 15 Mar 2017 13:58:56 +0100 Subject: [PATCH 2/2] Added ckeditor5-theme-lark to dependencies in package.json. --- package.json | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/package.json b/package.json index 7e67518..2ecded9 100644 --- a/package.json +++ b/package.json @@ -8,7 +8,8 @@ "@ckeditor/ckeditor5-ui": "^0.7.1", "@ckeditor/ckeditor5-utils": "^0.8.0", "@ckeditor/ckeditor5-engine": "^0.8.0", - "@ckeditor/ckeditor5-paragraph": "^0.6.1" + "@ckeditor/ckeditor5-paragraph": "^0.6.1", + "@ckeditor/ckeditor5-theme-lark": "^0.6.1" }, "devDependencies": { "@ckeditor/ckeditor5-dev-lint": "^2.0.2",