Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Selection#getSelectedBlocks #2442

Closed
scofalik opened this issue Feb 15, 2017 · 1 comment · Fixed by ckeditor/ckeditor5-heading#58
Closed

Use Selection#getSelectedBlocks #2442

scofalik opened this issue Feb 15, 2017 · 1 comment · Fixed by ckeditor/ckeditor5-heading#58
Labels
package:heading type:task This issue reports a chore (non-production change) and other types of "todos".
Milestone
iteration 9

Comments

@scofalik
Copy link
Contributor

In engine.model.Selection we introduced getSelectedBlocks method. Use it instead of providing own logic in Heading feature.
@oleq
Copy link
Member

oleq commented Mar 7, 2017

This will be included in https://github.com/ckeditor/ckeditor5-heading/issues/53.

szymonkups referenced this issue in ckeditor/ckeditor5-heading Mar 13, 2017
@szymonkups
Merge pull request #58 from ckeditor/t/53a
7a8f6f0 
Feature: Split "heading" command into independent commands. Closes #53. Closes #56. Closes #52.

BREAKING CHANGE: The "heading" command is no longer available. Replaced by "heading1", "heading2", "heading3" and "paragraph".
BREAKING CHANGE: `Heading` plugin requires `Paragraph` to work properly (`ParagraphCommand` registered as "paragraph" in `editor.commands`). 
BREAKING CHANGE: `config.heading.options` format has changed. The valid `HeadingOption` syntax is now `{ modelElement: 'heading1', viewElement: 'h1', title: 'Heading 1' }`.
@mlewand mlewand transferred this issue from ckeditor/ckeditor5-heading Oct 9, 2019
@mlewand mlewand added this to the iteration 9 milestone Oct 9, 2019
@mlewand mlewand added status:confirmed type:task This issue reports a chore (non-production change) and other types of "todos". package:heading labels Oct 9, 2019
@oleq oleq mentioned this issue Oct 11, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
package:heading type:task This issue reports a chore (non-production change) and other types of "todos".
Projects
None yet
Milestone
iteration 9
Development

Successfully merging a pull request may close this issue.

T/53a: Split "heading" command into independent commands. ckeditor/ckeditor5-heading
3 participants
@oleq @scofalik @mlewand