Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The dropdown label should not show "paragraph" when list item is selected #2440

Closed
Reinmar opened this issue Mar 13, 2017 · 1 comment · Fixed by ckeditor/ckeditor5-heading#64
Closed

The dropdown label should not show "paragraph" when list item is selected #2440

Reinmar opened this issue Mar 13, 2017 · 1 comment · Fixed by ckeditor/ckeditor5-heading#64
Assignees
@oleq
Labels
package:heading type:bug This issue reports a buggy (incorrect) behavior.
Milestone
iteration 9

Comments

@Reinmar
Copy link
Member

Reinmar commented Mar 13, 2017

mar-13-2017 19-08-52

This looks odd to me. It should show some default label, not "paragraph". In CKEditor 4 it showed "Formats". We don't use this term in the heading feature, but I can't think of something else. Maybe only "Headings"?
@oleq
Copy link
Member

oleq commented Mar 14, 2017

A good point. This is what you end up with if you only work on headings manual test, which does not load other features.

@oleq oleq self-assigned this Mar 14, 2017
oleq referenced this issue in ckeditor/ckeditor5-heading Mar 14, 2017
@oleq
Fixed: The default dropdown label should not be 'Paragraph'. Closes #62.
0142b45
oleq referenced this issue in ckeditor/ckeditor5-heading Mar 14, 2017
@oleq
Fix: The default dropdown label should not equal 'Paragraph'. Closes …
6090c26 
…#62.
szymonkups referenced this issue in ckeditor/ckeditor5-heading Mar 15, 2017
@szymonkups
Merge pull request #64 from ckeditor/t/62
e58dadc 
Fix: The default dropdown label shows 'Heading'. Closes #62.
@mlewand mlewand transferred this issue from ckeditor/ckeditor5-heading Oct 9, 2019
@mlewand mlewand added this to the iteration 9 milestone Oct 9, 2019
@mlewand mlewand added status:confirmed type:bug This issue reports a buggy (incorrect) behavior. package:heading labels Oct 9, 2019
@oleq oleq mentioned this issue Oct 11, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@oleq oleq

Labels
package:heading type:bug This issue reports a buggy (incorrect) behavior.
Projects
None yet
Milestone
iteration 9
Development

Successfully merging a pull request may close this issue.

t/62: The default dropdown label should not be 'Paragraph'. Closes #62. ckeditor/ckeditor5-heading
3 participants
@Reinmar @oleq @mlewand