Skip to content
This repository has been archived by the owner on Jun 26, 2020. It is now read-only.

Commit

Permalink
Merge pull request #178 from ckeditor/t/ckeditor5-theme-lark/135
Browse files Browse the repository at this point in the history
Other: Removed the `.ck-editor-toolbar` and `.ck-editor-toolbar-container` classes from the UI (see ckeditor/ckeditor5-theme-lark#135).
  • Loading branch information
oleq authored Feb 16, 2018
2 parents ae81506 + c632418 commit 1c08fdd
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 11 deletions.
9 changes: 1 addition & 8 deletions src/imagetoolbar.js
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ import ContextualBalloon from '@ckeditor/ckeditor5-ui/src/panel/balloon/contextu
import { isImageWidgetSelected } from './image/utils';
import { repositionContextualBalloon, getBalloonPositionData } from './image/ui/utils';

const balloonClassName = 'ck-toolbar-container ck-editor-toolbar-container';
const balloonClassName = 'ck-toolbar-container';

/**
* The image toolbar class. Creates an image toolbar that shows up when the image widget is selected.
Expand Down Expand Up @@ -69,13 +69,6 @@ export default class ImageToolbar extends Plugin {
*/
this._toolbar = new ToolbarView();

// Add CSS class to the toolbar.
this._toolbar.extendTemplate( {
attributes: {
class: 'ck-editor-toolbar'
}
} );

// Add buttons to the toolbar.
this._toolbar.fillFromConfig( toolbarConfig, editor.ui.componentFactory );

Expand Down
4 changes: 1 addition & 3 deletions tests/imagetoolbar.js
Original file line number Diff line number Diff line change
Expand Up @@ -79,11 +79,9 @@ describe( 'ImageToolbar', () => {

setData( model, '[<image src=""></image>]' );

expect( toolbar.element.classList.contains( 'ck-editor-toolbar' ) ).to.be.true;

sinon.assert.calledWithMatch( spy, {
view: toolbar,
balloonClassName: 'ck-toolbar-container ck-editor-toolbar-container'
balloonClassName: 'ck-toolbar-container'
} );
} );
} );
Expand Down

0 comments on commit 1c08fdd

Please sign in to comment.