Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Widget has fillers #5041

Closed
Reinmar opened this issue Dec 16, 2016 · 4 comments
Closed

Widget has fillers #5041

Reinmar opened this issue Dec 16, 2016 · 4 comments
Labels
package:image type:bug This issue reports a buggy (incorrect) behavior.
Milestone

Comments

@Reinmar
Copy link
Member

Reinmar commented Dec 16, 2016

image

@szymonkups szymonkups self-assigned this Feb 6, 2017
@szymonkups
Copy link
Contributor

I've pushed my progress to t/19 branch. We decided that we will leave this for now as the issue is bigger than it looked at the beginning.
Problem is that sometimes browser put selection inside contenteditable="false" element. I wanted to listen on selectionChange event and fix the selection before it is stored in model. Unfortunately, this causes some side-effects:
output

This happens:

  1. Selection is dragged, it ends up inside nested editable, so it's fixed to select whole widget.
  2. Selection is converted to model selection.
  3. Model to view selection conversion is done, widget is selected, and selection is put inside fake selection container.
  4. Selection is dragged further so 1st step occurs again.

In short, we are in a process of dragging selection in browser and at the same time we want to put selection inside fake selection container.

@Reinmar
Copy link
Member Author

Reinmar commented Mar 10, 2017

Another TC which we identified to be caused by the filler: https://github.com/ckeditor/ckeditor5-image/issues/69.

@Reinmar
Copy link
Member Author

Reinmar commented Jun 30, 2017

Another TC: #489.

@pjasiun
Copy link

pjasiun commented Oct 30, 2017

Fixed by ckeditor/ckeditor5-engine#1173.

@pjasiun pjasiun closed this as completed Oct 30, 2017
@mlewand mlewand transferred this issue from ckeditor/ckeditor5-image Oct 9, 2019
@mlewand mlewand added this to the iteration 13 milestone Oct 9, 2019
@mlewand mlewand added status:confirmed type:bug This issue reports a buggy (incorrect) behavior. package:image labels Oct 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package:image type:bug This issue reports a buggy (incorrect) behavior.
Projects
None yet
Development

No branches or pull requests

4 participants