-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The image must extend $block #5063
Comments
I wonder whether we should re-think what kind of abstract definitions we have in schema. Maybe having |
That's still open for me too. But I don't think that "block" is that bad. Image is a block element after all. It's just not a text container. |
Handling block images correctly will require https://github.com/ckeditor/ckeditor5-engine/issues/894. |
Once we'll make image a block, we also need to check if it's correctly handled in some merging scenarios on Backspace. E.g. ckeditor/ckeditor5-engine#907 (comment) |
We made caption inheriting from blocks in https://github.com/ckeditor/ckeditor5-image/pull/95/files which introduced https://github.com/ckeditor/ckeditor5-block-quote/issues/10 ;<. |
This was fixed once we refactored the schema. The |
As explained in https://github.com/ckeditor/ckeditor5-engine/issues/532#issuecomment-280919795.
It's a part of bigger refactoring which we need to make.
The text was updated successfully, but these errors were encountered: