-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The link panel is not displayed when selection spans the entire link element #4730
Comments
Alright. In F2F talk we decided with @oskarwrobel that this behaviour is valid and even expected in some sort of way. However, as @oskarwrobel pointed out, the panel should appear on double click on the link. I think it makes sense. It is something v4 users may be used to. |
OTOH, double clicking might be reserved for other editing tasks, like the user wants to select some text in the link and bold it. |
Hum... I still have the sensation that the panel should appear in such case. After all, the panel doesn't block other features to be executed over the selection, right? |
@fredck ATM I'm thinking about slightly different approach to opening the panel with mouse/keyboard because the problem is bigger, in fact. I'll submit it as another issue ASAP. |
@fredck I described the problem in https://github.com/ckeditor/ckeditor5-link/issues/26 (RFC!). If we drop "focus stealing" behaviour for mouse interactions, then we could always display the panel – for collapsed, non–collapsed, partial, and full selection in editable. |
I see that we agreed on ckeditor/ckeditor5-link#26 (I'm reviewing it now and it works great), so I assume that this issue is confirmed and we can open the balloon when entire link is selected (I agree with @fredck that this is expected behaviour). |
Can we have this fixed? It may sometimes (#116) be really confusing. |
Fix: The editing UI should show up when the selection encloses a link. Closes #23.
Expected: Link panel appears for the selected link.
Actual: Nothing happens.
The text was updated successfully, but these errors were encountered: