Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Link post fixer should retrun true if change something #4856

Closed
pjasiun opened this issue Jul 16, 2019 · 0 comments · Fixed by ckeditor/ckeditor5-link#245
Closed

Link post fixer should retrun true if change something #4856

pjasiun opened this issue Jul 16, 2019 · 0 comments · Fixed by ckeditor/ckeditor5-link#245
Assignees
@msamsel
Labels
package:link type:bug This issue reports a buggy (incorrect) behavior.
Milestone
iteration 26

Comments

@pjasiun
Copy link

pjasiun commented Jul 16, 2019

As described in the documentation view post-fixer should return true if changing something. However, link post-fixer return nothing: https://github.com/ckeditor/ckeditor5-link/blob/2f838afc752a69167521f527d652e42b298a2204/src/linkediting.js#L200-L214
@pjasiun pjasiun changed the title Link post fixer should retrun true is change something Link post fixer should retrun true if change something Jul 16, 2019
jodator referenced this issue in ckeditor/ckeditor5-link Aug 1, 2019
@jodator
Merge pull request #245 from ckeditor/t/241
14e5803 
Fix: Add missing return value for link post-fixer. Closes #241.
@mlewand mlewand transferred this issue from ckeditor/ckeditor5-link Oct 9, 2019
@mlewand mlewand added this to the iteration 26 milestone Oct 9, 2019
@mlewand mlewand added status:confirmed type:bug This issue reports a buggy (incorrect) behavior. package:link labels Oct 9, 2019
@msamsel msamsel mentioned this issue Oct 11, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@msamsel msamsel

Labels
package:link type:bug This issue reports a buggy (incorrect) behavior.
Projects
None yet
Milestone
iteration 26
Development

Successfully merging a pull request may close this issue.

Add missing return value for link postfixer ckeditor/ckeditor5-link
3 participants
@pjasiun @mlewand @msamsel