Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handling h1 headers #2479

Closed
f1ames opened this issue Aug 6, 2018 · 1 comment · Fixed by ckeditor/ckeditor5-heading#114
Closed

Handling h1 headers #2479

f1ames opened this issue Aug 6, 2018 · 1 comment · Fixed by ckeditor/ckeditor5-heading#114
Labels
package:paste-from-office status:discussion type:improvement This issue reports a possible enhancement of an existing feature.
Milestone

Comments

@f1ames
Copy link
Contributor

f1ames commented Aug 6, 2018

Extracted from #1184.

As pointed out by @wwalc in #1184 (comment), pasting headers technically works (tags are correctly transformed), but since CKEditor supports h2 to h4 by default, h1 is transformed into paragraph which is quite confusing.

We need to think about some reasonable solution:

@Reinmar
Copy link
Member

Reinmar commented Sep 24, 2018

I think we need to finally resolve https://github.com/ckeditor/ckeditor5-heading/issues/98. And this doesn't touch MS Word – it touches all data, all pasted content. We should resolve that thing and then check if there's anything special that we need to do for MS Word.

Reinmar referenced this issue in ckeditor/ckeditor5-heading Oct 30, 2018
Other: The `<h1>` elements are now converted to `<heading1>` elements instead of being converted to `<paragraph>`s by default. Closes #98. Closes ckeditor/ckeditor5-paste-from-office#2.
@mlewand mlewand transferred this issue from ckeditor/ckeditor5-paste-from-office Oct 9, 2019
@mlewand mlewand added this to the iteration 21 milestone Oct 9, 2019
@mlewand mlewand added status:discussion type:improvement This issue reports a possible enhancement of an existing feature. package:paste-from-office labels Oct 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package:paste-from-office status:discussion type:improvement This issue reports a possible enhancement of an existing feature.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants