diff --git a/src/useMultiRootEditor.tsx b/src/useMultiRootEditor.tsx index 2edde77..301550a 100644 --- a/src/useMultiRootEditor.tsx +++ b/src/useMultiRootEditor.tsx @@ -505,7 +505,7 @@ const useMultiRootEditor = ( props: MultiRootHookProps ): MultiRootHookReturns = data || /* istanbul ignore next -- @preserve: It should never happen, data should be always filled. */ {} ); - const hasModifiedData = dataKeys.some( rootName => + const modifiedRoots = dataKeys.filter( rootName => editorData[ rootName ] !== undefined && JSON.stringify( editorData[ rootName ] ) !== JSON.stringify( data[ rootName ] ) ); @@ -530,12 +530,12 @@ const useMultiRootEditor = ( props: MultiRootHookProps ): MultiRootHookReturns = } ); }; - const _updateEditorData = () => { - // If any of the roots content has changed, set the editor data. - // Unfortunately, we cannot set the editor data just for one root, - // so we need to overwrite all roots (`nextProps.data` is an - // object with data for each root). - instance.data.set( data, { suppressErrorInCollaboration: true } as any ); + const _updateEditorData = ( roots: Array ) => { + const dataToUpdate = roots.reduce( + ( result, rootName ) => ( { ...result, [ rootName ]: data[ rootName ] } ), + Object.create( null ) + ); + instance.data.set( dataToUpdate, { suppressErrorInCollaboration: true } as any ); }; const _updateEditorAttributes = ( writer: Writer, roots: Array ) => { @@ -555,8 +555,8 @@ const useMultiRootEditor = ( props: MultiRootHookProps ): MultiRootHookReturns = _handleNewRoots( newRoots ); _handleRemovedRoots( removedRoots ); - if ( hasModifiedData ) { - _updateEditorData(); + if ( modifiedRoots.length ) { + _updateEditorData( modifiedRoots ); } if ( rootsWithChangedAttributes.length ) { diff --git a/tests/useMultiRootEditor.test.tsx b/tests/useMultiRootEditor.test.tsx index 31551a8..8f82e0c 100644 --- a/tests/useMultiRootEditor.test.tsx +++ b/tests/useMultiRootEditor.test.tsx @@ -19,7 +19,8 @@ import turnOffDefaultErrorCatching from './_utils/turnoffdefaulterrorcatching.js describe( 'useMultiRootEditor', () => { const rootsContent = { intro: '

Sample

This is an instance of the.

', - content: '

It is the custom content

' + content: '

It is the custom content

', + footer: '

Footer content

' }; const rootsAttributes = { @@ -30,6 +31,10 @@ describe( 'useMultiRootEditor', () => { content: { row: '1', order: 20 + }, + footer: { + row: '2', + order: 30 } }; @@ -232,7 +237,7 @@ describe( 'useMultiRootEditor', () => { const { data, editableElements } = result.current; expect( data ).to.deep.equal( rootsContent ); - expect( editableElements.length ).to.equal( 2 ); + expect( editableElements.length ).to.equal( 3 ); } ); it( 'should update the editor data when the state has been changed', async () => { @@ -254,8 +259,64 @@ describe( 'useMultiRootEditor', () => { expect( spy ).toHaveBeenCalledOnce(); expect( data.intro ).to.equal( '

New data

' ); - expect( editableElements.length ).to.equal( 2 ); + expect( data.content ).to.equal( rootsContent.content ); + expect( data.footer ).to.equal( rootsContent.footer ); + expect( spy.mock.calls[ 0 ][ 0 ] ).to.deep.equal( { 'intro': 'New data' } ); + expect( editableElements.length ).to.equal( 3 ); expect( editor!.getFullData().intro ).to.equal( '

New data

' ); + expect( editor!.getFullData().content ).to.equal( rootsContent.content ); + expect( editor!.getFullData().footer ).to.equal( rootsContent.footer ); + } ); + } ); + + it( 'should update only editor roots which content have been changed', async () => { + const { result } = renderHook( () => useMultiRootEditor( editorProps ) ); + + await waitFor( () => { + expect( result.current.editor ).to.be.instanceof( TestMultiRootEditor ); + } ); + + const { editor, setData } = result.current; + const spy = vi.spyOn( editor!.data, 'set' ); + + act( () => { + setData( { ...rootsContent, 'intro': '

Sample

', 'footer': 'Text...' } ); + } ); + + await waitFor( () => { + const { data, editableElements } = result.current; + + expect( spy ).toHaveBeenCalledOnce(); + expect( data.intro ).to.equal( '

Sample

' ); + expect( data.footer ).to.equal( '

Text...

' ); + expect( spy.mock.calls[ 0 ][ 0 ] ).to.deep.equal( { 'intro': '

Sample

', 'footer': 'Text...' } ); + expect( editableElements.length ).to.equal( 3 ); + expect( editor!.getFullData().intro ).to.equal( '

Sample

' ); + expect( editor!.getFullData().footer ).to.equal( '

Text...

' ); + } ); + } ); + + it( 'should not update editor roots when no content have been changed', async () => { + const { result } = renderHook( () => useMultiRootEditor( editorProps ) ); + + await waitFor( () => { + expect( result.current.editor ).to.be.instanceof( TestMultiRootEditor ); + } ); + + const { editor, setData } = result.current; + const spy = vi.spyOn( editor!.data, 'set' ); + + act( () => { + setData( { ...rootsContent, 'intro': '

Sample

This is an instance of the.

' } ); + } ); + + await waitFor( () => { + const { data, editableElements } = result.current; + + expect( spy.mock.calls.length ).to.equal( 0 ); + expect( data ).to.deep.equal( rootsContent ); + expect( editableElements.length ).to.equal( 3 ); + expect( editor!.getFullData() ).to.deep.equal( rootsContent ); } ); } ); @@ -281,7 +342,7 @@ describe( 'useMultiRootEditor', () => { expect( spy ).toHaveBeenCalledOnce(); expect( data.intro ).to.be.undefined; - expect( editableElements.length ).to.equal( 1 ); + expect( editableElements.length ).to.equal( 2 ); expect( editor!.getFullData().intro ).to.be.undefined; } ); } ); @@ -306,7 +367,7 @@ describe( 'useMultiRootEditor', () => { expect( spy ).toHaveBeenCalledOnce(); expect( data.outro ).to.be.equal( '

New data

' ); - expect( editableElements.length ).to.equal( 3 ); + expect( editableElements.length ).to.equal( 4 ); expect( editor!.getFullData().outro ).to.be.equal( '

New data

' ); } ); } ); @@ -328,7 +389,7 @@ describe( 'useMultiRootEditor', () => { const { data, editableElements } = result.current; expect( data.intro ).to.equal( '

New data

' ); - expect( editableElements.length ).to.equal( 2 ); + expect( editableElements.length ).to.equal( 3 ); expect( editor!.getFullData().intro ).to.equal( '

New data

' ); } ); } ); @@ -354,7 +415,7 @@ describe( 'useMultiRootEditor', () => { expect( spy.mock.calls.length ).to.equal( editableElements.length ); expect( data.outro ).to.equal( '' ); expect( attributes.outro ).to.deep.equal( { order: null, row: null } ); - expect( editableElements.length ).to.equal( 3 ); + expect( editableElements.length ).to.equal( 4 ); expect( editor!.getFullData().outro ).to.equal( '' ); } ); @@ -396,7 +457,7 @@ describe( 'useMultiRootEditor', () => { const { editor } = result.current; - expect( result.current.editableElements.length ).to.equal( 2 ); + expect( result.current.editableElements.length ).to.equal( 3 ); act( () => { editor!.detachRoot( 'intro' ); @@ -406,7 +467,7 @@ describe( 'useMultiRootEditor', () => { const { data, editableElements } = result.current; expect( data.intro ).to.be.undefined; - expect( editableElements.length ).to.equal( 1 ); + expect( editableElements.length ).to.equal( 2 ); expect( editor!.getFullData().intro ).to.be.undefined; } ); } ); @@ -718,7 +779,7 @@ describe( 'useMultiRootEditor', () => { const { data, editableElements } = result.current; expect( data.intro ).to.equal( rootsContent.intro ); - expect( editableElements.length ).to.equal( 2 ); + expect( editableElements.length ).to.equal( 3 ); expect( editor!.getFullData().intro ).to.equal( '

New data

' ); expect( getDataSpy ).not.toHaveBeenCalled(); } ); @@ -747,7 +808,7 @@ describe( 'useMultiRootEditor', () => { expect( spy.mock.calls.length ).to.equal( editableElements.length ); expect( data.outro ).to.be.undefined; expect( attributes.outro ).to.be.undefined; - expect( editableElements.length ).to.equal( 3 ); + expect( editableElements.length ).to.equal( 4 ); expect( editor!.getFullData().outro ).to.equal( '' ); } ); @@ -763,7 +824,7 @@ describe( 'useMultiRootEditor', () => { const { editor } = result.current; - expect( result.current.editableElements.length ).to.equal( 2 ); + expect( result.current.editableElements.length ).to.equal( 3 ); act( () => { editor!.detachRoot( 'intro' ); @@ -773,7 +834,7 @@ describe( 'useMultiRootEditor', () => { const { data, editableElements } = result.current; expect( data.intro ).to.be.equal( rootsContent.intro ); - expect( editableElements.length ).to.equal( 1 ); + expect( editableElements.length ).to.equal( 2 ); expect( editor!.getFullData().intro ).to.be.undefined; } ); } ); @@ -1029,7 +1090,7 @@ describe( 'useMultiRootEditor', () => { await waitFor( () => { expect( renderedEditor.current ).not.to.be.null; - expect( container.getElementsByClassName( 'ck-editor__editable' ).length ).to.equal( 2 ); + expect( container.getElementsByClassName( 'ck-editor__editable' ).length ).to.equal( 3 ); } ); renderedEditor.current!.model.document.roots.remove( 'intro' ); @@ -1104,7 +1165,7 @@ describe( 'useMultiRootEditor', () => { const { container } = render( ); await waitFor( () => { - expect( container.getElementsByClassName( 'ck-editor__editable' ).length ).to.equal( 2 ); + expect( container.getElementsByClassName( 'ck-editor__editable' ).length ).to.equal( 3 ); } ); } );