Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plugin crashes with spaces in HTML-Code with tables #3251

Closed
ckotzbauer opened this issue Nov 8, 2018 · 6 comments · Fixed by ckeditor/ckeditor5-table#146
Closed

Plugin crashes with spaces in HTML-Code with tables #3251

ckotzbauer opened this issue Nov 8, 2018 · 6 comments · Fixed by ckeditor/ckeditor5-table#146
Assignees
Labels
package:table type:bug This issue reports a buggy (incorrect) behavior.
Milestone

Comments

@ckotzbauer
Copy link

Hi,

we figured out the following issue with the table plugin:

editor.setData('<table><tbody><tr><td>First row</td></tr><tr><td>Second row</td></tr><tr><td>Third row</td></tr> <tr><td>Fourth row</td></tr></tbody></table>')

This causes the following error (reproducable with current master build on ckeditor.com):

Uncaught TypeError: t.getChildren is not a function
    at Cg (upcasttable.js:223)
    at upcasttable.js:194
    at Ia.t.on (upcasttable.js:31)
    at Ia.fire (emittermixin.js:196)
    at Ia._convertItem (upcastdispatcher.js:212)
    at Ia._convertChildren (upcastdispatcher.js:243)
    at Ia.La.upcastDispatcher.on (upcast-converters.js:584)
    at Ia.fire (emittermixin.js:196)
    at Ia._convertItem (upcastdispatcher.js:216)
    at Ia.convert (upcastdispatcher.js:171)

If we remove the space between the third and fourth-row tr-tag, all works fine.

Can someone of you investigate here?

Thanks!

@Reinmar
Copy link
Member

Reinmar commented Nov 8, 2018

Confirmed, thanks.

@Reinmar
Copy link
Member

Reinmar commented Nov 8, 2018

@Reinmar
Copy link
Member

Reinmar commented Nov 8, 2018

PR: ckeditor/ckeditor5-table#146

@ckotzbauer
Copy link
Author

@Reinmar
Is there a estimation date-range when this can be fixed? Our customers found this bug in production, so maybe we have to create a workaround until this is fixed in CK.

@Reinmar
Copy link
Member

Reinmar commented Nov 8, 2018

We plan a code freeze in 1-2 weeks and then 1-2 weeks for a testing phase and preparing the release, so 3-4 weeks. You shouldn't have a problem to backport the patch from the PR to the last release, though.

jodator referenced this issue in ckeditor/ckeditor5-table Nov 8, 2018
Fix: Skip text nodes between `tr` elements during table upcast. Closes #145.
@ckotzbauer
Copy link
Author

Works like charm, thanks for that quick bugfix!

@mlewand mlewand transferred this issue from ckeditor/ckeditor5-table Oct 9, 2019
@mlewand mlewand added this to the iteration 21 milestone Oct 9, 2019
@mlewand mlewand added status:confirmed type:bug This issue reports a buggy (incorrect) behavior. package:table labels Oct 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package:table type:bug This issue reports a buggy (incorrect) behavior.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants