Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove support for deprecated table.toolbar. #3259

Closed
ma2ciek opened this issue Jan 29, 2019 · 2 comments · Fixed by ckeditor/ckeditor5-table#188
Closed

Remove support for deprecated table.toolbar. #3259

ma2ciek opened this issue Jan 29, 2019 · 2 comments · Fixed by ckeditor/ckeditor5-table#188
Assignees
@msamsel
Labels
package:table type:task This issue reports a chore (non-production change) and other types of "todos".
Milestone
iteration 24

Comments

@ma2ciek
Copy link
Contributor

ma2ciek commented Jan 29, 2019

In the next major release, we should remove that property from being supported.
@oleq
Copy link
Member

oleq commented Jan 31, 2019

When was it deprecated and by what?

@ma2ciek
Copy link
Contributor Author

ma2ciek commented Jan 31, 2019

It was deprecated in the https://github.com/ckeditor/ckeditor5-table/releases/tag/v11.0.0.

Actually, it's already in the BREAKING CHANGES... I guess it was a mistake. We could skip the warning and remove the support for it since we had other breaking changes in that release.

mlewand referenced this issue in ckeditor/ckeditor5-table May 20, 2019
@mlewand
Other: Removed deprecated config.table.toolbar configuration option…
5d024ce 
…. Closes #167.

BREAKING CHANGE: `config.table.toolbar` is now removed from code. Use `config.table.contentToolbar`instead.
@mlewand mlewand transferred this issue from ckeditor/ckeditor5-table Oct 9, 2019
@mlewand mlewand added this to the iteration 24 milestone Oct 9, 2019
@mlewand mlewand added status:confirmed type:task This issue reports a chore (non-production change) and other types of "todos". package:table labels Oct 9, 2019
@msamsel msamsel mentioned this issue Oct 11, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@msamsel msamsel

Labels
package:table type:task This issue reports a chore (non-production change) and other types of "todos".
Projects
None yet
Milestone
iteration 24
Development

Successfully merging a pull request may close this issue.

Remove deprecated configuration option. ckeditor/ckeditor5-table
4 participants
@oleq @ma2ciek @mlewand @msamsel