Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding a row on tab key should use a command #3268

Closed
scofalik opened this issue May 6, 2019 · 0 comments · Fixed by ckeditor/ckeditor5-table#186
Closed

Adding a row on tab key should use a command #3268

scofalik opened this issue May 6, 2019 · 0 comments · Fixed by ckeditor/ckeditor5-table#186
Assignees
@scofalik
Labels
package:table type:task This issue reports a chore (non-production change) and other types of "todos".
Milestone
iteration 24

Comments

@scofalik
Copy link
Contributor

scofalik commented May 6, 2019

At the moment, if Tab key is pressed in the last cell of the table a new table row is created and the caret is moved there. This is "hardcoded" - doesn't use insertTableRowBelow command. This is incorrect as the command (and all other commands) might be disabled if the table is not editable for some reason (for example, comments-only mode). It will also be better for integration with track changes.
@scofalik scofalik self-assigned this May 6, 2019
jodator referenced this issue in ckeditor/ckeditor5-table May 6, 2019
@jodator
Merge pull request #186 from ckeditor/t/185
00848a8 
Fix: Table rows will not be added on tab key press if the associated command is disabled. Closes #185.
@mlewand mlewand transferred this issue from ckeditor/ckeditor5-table Oct 9, 2019
@mlewand mlewand added this to the iteration 24 milestone Oct 9, 2019
@mlewand mlewand added type:task This issue reports a chore (non-production change) and other types of "todos". package:table labels Oct 9, 2019
@scofalik scofalik mentioned this issue Oct 11, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@scofalik scofalik

Labels
package:table type:task This issue reports a chore (non-production change) and other types of "todos".
Projects
None yet
Milestone
iteration 24
2 participants
@scofalik @mlewand