Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better error message when try to add not existing component to toolbar config #5321

Closed
oskarwrobel opened this issue Mar 26, 2017 · 0 comments · Fixed by ckeditor/ckeditor5-ui#175
Closed

Better error message when try to add not existing component to toolbar config #5321

oskarwrobel opened this issue Mar 26, 2017 · 0 comments · Fixed by ckeditor/ckeditor5-ui#175
Assignees
@oleq
Labels
package:ui type:improvement This issue reports a possible enhancement of an existing feature.
Milestone
iteration 9

Comments

@oskarwrobel
Copy link
Contributor

Now is:

TypeError: this._components.get(...) is not a function.
@oleq oleq self-assigned this Mar 27, 2017
oleq referenced this issue in ckeditor/ckeditor5-ui Mar 27, 2017
@oleq
Other: Throw an error when attempting to create a component not regis…
4b0b394 
…tered in ComponentFactory. Closes #174.
Reinmar referenced this issue in ckeditor/ckeditor5-ui Mar 27, 2017
@Reinmar
Merge pull request #175 from ckeditor/t/174
ef0a7f8 
Other: `ComponentFactory` will throw an error when attempting to create a non-existent component. Closes #174.
@mlewand mlewand transferred this issue from ckeditor/ckeditor5-ui Oct 9, 2019
@mlewand mlewand added this to the iteration 9 milestone Oct 9, 2019
@mlewand mlewand added status:confirmed type:improvement This issue reports a possible enhancement of an existing feature. package:ui labels Oct 9, 2019
@oleq oleq mentioned this issue Oct 11, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@oleq oleq

Labels
package:ui type:improvement This issue reports a possible enhancement of an existing feature.
Projects
None yet
Milestone
iteration 9
3 participants
@oskarwrobel @oleq @mlewand