Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Position of balloons should be updated on external changes #5338

Closed
oskarwrobel opened this issue Apr 10, 2017 · 2 comments · Fixed by ckeditor/ckeditor5-ui#217
Closed

Position of balloons should be updated on external changes #5338

oskarwrobel opened this issue Apr 10, 2017 · 2 comments · Fixed by ckeditor/ckeditor5-ui#217
Assignees
@oskarwrobel
Labels
package:ui type:improvement This issue reports a possible enhancement of an existing feature.
Milestone
iteration 10

Comments

@oskarwrobel
Copy link
Contributor

The first user clicks on link element and sees balloon panel attached to this element. The second user types something before this link element. The result: link element is moving but attached balloon stays at the same position.
@oleq
Copy link
Member

oleq commented Apr 10, 2017

I think it's enough to call pin() on editor.editing.view#render and it's up to the features using the BalloonPanelView to do this. The UI library should not be aware of the engine and vice-versa unless we'd like to deal with some very cumbersome dependencies in the project.

@oskarwrobel
Copy link
Contributor Author

it's up to the features using the BalloonPanelView to do this.

👍

@oskarwrobel oskarwrobel self-assigned this Apr 24, 2017
@oskarwrobel oskarwrobel changed the title Position of balloons should be updated on changes from collaboration Position of balloons should be updated on external changes Apr 24, 2017
oleq referenced this issue in ckeditor/ckeditor5-ui Apr 26, 2017
@oleq
Merge pull request #217 from ckeditor/t/198
4fc089f 
Tests: Added a manual test to check `ContextualToolbar` integration with external document changes. Closes #198.
@mlewand mlewand transferred this issue from ckeditor/ckeditor5-ui Oct 9, 2019
@mlewand mlewand added this to the iteration 10 milestone Oct 9, 2019
@mlewand mlewand added status:confirmed type:improvement This issue reports a possible enhancement of an existing feature. package:ui labels Oct 9, 2019
@oskarwrobel oskarwrobel mentioned this issue Oct 11, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@oskarwrobel oskarwrobel

Labels
package:ui type:improvement This issue reports a possible enhancement of an existing feature.
Projects
None yet
Milestone
iteration 10
Development

Successfully merging a pull request may close this issue.

Added manual test to check balloons position after external changes. ckeditor/ckeditor5-ui
3 participants
@oskarwrobel @oleq @mlewand