Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change contextualToolbar#beforeShow to contextualToolbar#show #5361

Closed
pjasiun opened this issue May 15, 2017 · 1 comment · Fixed by ckeditor/ckeditor5-ui#276
Closed

Change contextualToolbar#beforeShow to contextualToolbar#show #5361

pjasiun opened this issue May 15, 2017 · 1 comment · Fixed by ckeditor/ckeditor5-ui#276
Labels
package:ui type:improvement This issue reports a possible enhancement of an existing feature.
Milestone
iteration 11

Comments

@pjasiun
Copy link

pjasiun commented May 15, 2017

Once we will get rid of this promise https://github.com/ckeditor/ckeditor5-ui/blob/827edae3522e20220a26c1430c5392cdc18404bd/src/toolbar/contextual/contextualtoolbar.js#L153 we should change the contextualToolbar#beforeShow event to contextualToolbar#show end execute the default action on this event with the low priority.

It means that instead of:

contextualToolbar.on( 'beforeShow', ( evt, stop ) => {
     stop();
} );

I should be able to do:

contextualToolbar.on( 'show', evt => {
     evt.stop();
} );
@oleq oleq changed the title Change contextualToolbar#beforeShow to contextualToolbar#show Change contextualToolbar#beforeShow to contextualToolbar#show May 15, 2017
@oleq
Copy link
Member

oleq commented May 15, 2017

Related issue https://github.com/ckeditor/ckeditor5-ui/issues/225.

oleq referenced this issue in ckeditor/ckeditor5-ui Jul 18, 2017
@oleq
Merge pull request #276 from ckeditor/t/269
d83d07d 
Other: The `ContextualToolbar` should not show up when all child items are disabled. The `ContextualToolbar#beforeShow` event has been replaced by `ContextualToolbar#show`. Closes #269. Closes #232.

BREAKING CHANGE: `ContextualToolbar#beforeShow` is no longer available. Please refer to `ContextualToolbar#show` instead.
@mlewand mlewand transferred this issue from ckeditor/ckeditor5-ui Oct 9, 2019
@mlewand mlewand added this to the iteration 11 milestone Oct 9, 2019
@mlewand mlewand added status:confirmed type:improvement This issue reports a possible enhancement of an existing feature. package:ui labels Oct 9, 2019
@oskarwrobel oskarwrobel mentioned this issue Oct 11, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
package:ui type:improvement This issue reports a possible enhancement of an existing feature.
Projects
None yet
Milestone
iteration 11
Development

Successfully merging a pull request may close this issue.

ContextualToolbar is not displayed when all components inside are disabled. ckeditor/ckeditor5-ui
3 participants
@oleq @pjasiun @mlewand