Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DropdownView should open upon arrow down key press #5371

Closed
oleq opened this issue Jun 13, 2017 · 0 comments · Fixed by ckeditor/ckeditor5-ui#251
Closed

DropdownView should open upon arrow down key press #5371

oleq opened this issue Jun 13, 2017 · 0 comments · Fixed by ckeditor/ckeditor5-ui#251
Assignees
@oleq
Labels
package:ui type:bug This issue reports a buggy (incorrect) behavior.
Milestone
iteration 11

Comments

@oleq
Copy link
Member

oleq commented Jun 13, 2017

A regression after https://github.com/ckeditor/ckeditor5-ui/issues/238.

It turned out none of the dropdown's observables except #isOpen actually works because the model passed to createDropdown() helper directly binds these attributes in dropdownView#buttonView instead. The documentation is misleading and hence the regression.
@oleq oleq self-assigned this Jun 13, 2017
@oleq oleq changed the title DropdownPanelView should open upon arrow down key press DropdownView should open upon arrow down key press Jun 13, 2017
oleq referenced this issue in ckeditor/ckeditor5-ui Jun 13, 2017
@oleq
Fix: DropdownView should open upon arrow down key press. Closes #249.
9dfc076
oskarwrobel referenced this issue in ckeditor/ckeditor5-ui Jun 13, 2017
@oskarwrobel
Merge pull request #251 from ckeditor/t/249
c1e6afc 
Fix: DropdownView should open upon arrow down key press. Closes #249.
@mlewand mlewand transferred this issue from ckeditor/ckeditor5-ui Oct 9, 2019
@mlewand mlewand added this to the iteration 11 milestone Oct 9, 2019
@mlewand mlewand added type:bug This issue reports a buggy (incorrect) behavior. package:ui labels Oct 9, 2019
@oleq oleq mentioned this issue Oct 11, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@oleq oleq

Labels
package:ui type:bug This issue reports a buggy (incorrect) behavior.
Projects
None yet
Milestone
iteration 11
Development

Successfully merging a pull request may close this issue.

t/249: DropdownView should open upon arrow down key press. ckeditor/ckeditor5-ui
2 participants
@oleq @mlewand