Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement public show/hide methods in ContextualToolbar (independent of focus and selection) #5383

Closed
oleq opened this issue Jul 3, 2017 · 2 comments · Fixed by ckeditor/ckeditor5-ui#270
Closed

Implement public show/hide methods in ContextualToolbar (independent of focus and selection) #5383

oleq opened this issue Jul 3, 2017 · 2 comments · Fixed by ckeditor/ckeditor5-ui#270
Assignees
@oleq
Labels
package:ui type:improvement This issue reports a possible enhancement of an existing feature.
Milestone
iteration 11

Comments

@oleq
Copy link
Member

oleq commented Jul 3, 2017

#It's a follow–up of https://github.com/ckeditor/ckeditor5-editor-balloon-toolbar/issues/3.

ATM there's no way to show or hide ContextualToolbar when the seleciton is collapsed. To implement a decent keystroke support in editor-balloon-toolbar, ContextualToolbar must get a public show/hide API.

The API must be independent of editingView.isFocused and editingView.selection.isCollapsed , which means the current behavior of the toolbar will be moved to _selectionChangeDebounced event listener.

Additionally, enableToolbarKeyboardFocus() helper must get beforeShow and afterShow options to make sure the toolbar is shown and hidden on Alt+10 and Esc.
@oleq oleq self-assigned this Jul 3, 2017
@oleq
Copy link
Member Author

oleq commented Jul 3, 2017

The implementation is in https://github.com/ckeditor/ckeditor5-ui/tree/t/263 and awaits https://github.com/ckeditor/ckeditor5-ui/issues/225.

Without #5355, there's no way to write proper enableToolbarKeyboardFocus() tests because the content of beforeEach is asynchronous at this moment and the EmitterMixin does not support async on() events.

@oskarwrobel
Copy link
Contributor

This is related to #340 (comment).

oleq referenced this issue in ckeditor/ckeditor5-ui Jul 10, 2017
@oleq
Other: Implemented public show and hide methods in the ContextualTool…
870c165 
…bar plugin. Closes #263.

Extended enableToolbarKeyboardFocus helper with beforeFocus and afterBlur callbacks.
Reinmar referenced this issue in ckeditor/ckeditor5-ui Jul 12, 2017
@Reinmar
Merge pull request #270 from ckeditor/t/263
eb4caab 
Other: Implemented public `show()` and `hide()` methods in the `ContextualToolbar` plugin. Closes #263.
oleq referenced this issue in ckeditor/ckeditor5-image Jul 12, 2017
@oleq
Tests: Aligned Image tests to the latest ContextualToolbar API (see c…
d4e52de 
…keditor/ckeditor5-ui#263).
@mlewand mlewand transferred this issue from ckeditor/ckeditor5-ui Oct 9, 2019
@mlewand mlewand added this to the iteration 11 milestone Oct 9, 2019
@mlewand mlewand added status:confirmed type:improvement This issue reports a possible enhancement of an existing feature. package:ui labels Oct 9, 2019
@oleq oleq mentioned this issue Oct 11, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@oleq oleq

Labels
package:ui type:improvement This issue reports a possible enhancement of an existing feature.
Projects
None yet
Milestone
iteration 11
3 participants
@oskarwrobel @oleq @mlewand