Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for URLs to icons (as addition to icon source) #5397

Closed
Reinmar opened this issue Aug 30, 2017 · 3 comments
Closed

Support for URLs to icons (as addition to icon source) #5397

Reinmar opened this issue Aug 30, 2017 · 3 comments
Labels
package:ui resolution:expired This issue was closed due to lack of feedback. status:stale type:feature This issue reports a feature request (an idea for a new functionality or a missing option).

Comments

@Reinmar
Copy link
Member

Reinmar commented Aug 30, 2017

Right now we support only SVG sources which works great when you're building an editor.

But if you already use a build and you'd like to quickly configure e.g. image styles then you need to take SVG source from somewhere.

We might propose some little tricks to be used on such occasions (e.g. a way to convert an SVG file which you have somewhere on our HTTP server to a source on the fly – i.e. via JS in the browser). But that will be cumbersome and limiting. It'd be better if the icon view handled URLs to icons as an addition to handling SVG sources.

Will this be possible?

If so, I'd propose to change IconView#content to IconView#source. ButtonView#icon is fine.

@Reinmar Reinmar changed the title Support for URLs to icons instead of icon source Support for URLs to icons (as addition to icon source) Aug 30, 2017
@Reinmar
Copy link
Member Author

Reinmar commented Aug 31, 2017

I removed this ticket from the milestone because https://github.com/ckeditor/ckeditor5-image/issues/134 and https://github.com/ckeditor/ckeditor5-image/issues/135 will solve the root of the issue that we have now.

@mlewand mlewand transferred this issue from ckeditor/ckeditor5-ui Oct 9, 2019
@mlewand mlewand added this to the backlog milestone Oct 9, 2019
@mlewand mlewand added status:confirmed type:feature This issue reports a feature request (an idea for a new functionality or a missing option). package:ui labels Oct 9, 2019
@pomek pomek removed this from the backlog milestone Feb 21, 2022
@CKEditorBot
Copy link
Collaborator

There has been no activity on this issue for the past year. We've marked it as stale and will close it in 30 days. We understand it may be relevant, so if you're interested in the solution, leave a comment or reaction under this issue.

@CKEditorBot
Copy link
Collaborator

We've closed your issue due to inactivity over the last year. We understand that the issue may still be relevant. If so, feel free to open a new one (and link this issue to it).

@CKEditorBot CKEditorBot added the resolution:expired This issue was closed due to lack of feedback. label Nov 2, 2023
@CKEditorBot CKEditorBot closed this as not planned Won't fix, can't repro, duplicate, stale Nov 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package:ui resolution:expired This issue was closed due to lack of feedback. status:stale type:feature This issue reports a feature request (an idea for a new functionality or a missing option).
Projects
None yet
Development

No branches or pull requests

4 participants