Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Tests] Broken image toolbar manual test #5403

Closed
oleq opened this issue Sep 14, 2017 · 2 comments · Fixed by ckeditor/ckeditor5-ui#332
Closed

[Tests] Broken image toolbar manual test #5403

oleq opened this issue Sep 14, 2017 · 2 comments · Fixed by ckeditor/ckeditor5-ui#332
Assignees
@oleq
Labels
package:ui type:bug This issue reports a buggy (incorrect) behavior.
Milestone
iteration 13

Comments

@oleq
Copy link
Member

oleq commented Sep 14, 2017

http://localhost:8125/ckeditor5-ui/tests/manual/imagetoolbar/imagetoolbar.html shows errors and won't start.
@oleq oleq self-assigned this Sep 20, 2017
@oleq
Copy link
Member Author

oleq commented Sep 20, 2017

While fixing this test I noticed that... it's no longer necessary. The functionality has been replaced by ContextualBalloon and ContextualToolbar

We no longer use BalloonPanelView#pin to implement such features and I think maintaining this test is pointless. WDYT @oskarwrobel?

@oskarwrobel
Copy link
Contributor

Yes, I think this test makes no sense anymore. But I can't find any ImageToolbar MT testing how it works now. I mean howImageToolbar works using ContextualBalloon. We have MT for ImageTextAlternative balloon but we don't have a similar test for ImageToolbar.

Actually, we are able to test ImageToolbar using ImageTextAlternative test.

oskarwrobel referenced this issue in ckeditor/ckeditor5-ui Nov 2, 2017
@oskarwrobel
Merge pull request #332 from ckeditor/t/262
bf90ad5 
Other: Implemented `View#render` method which replaces the `#element` rendering upon the first reference and incorporates the `#init` method functionality. Closes #262. Closes #302.

From now on `View#setTemplate` and `View#extendTemplate` methods are recommended as a shorthand for `view.template = new Template( { ... } )` and `Template.extend( view.template )`.

BREAKING CHANGE: The `init()` method in various UI components has been renamed to `render()`. Please refer to the documentation to learn more.

BREAKING CHANGE: The `View#element` is no longer a getter which renders an element when first referenced. Use the `View#render()` method instead.

BREAKING CHANGE: `Template#children` property became an `Array` (previously `ViewCollection`).

BREAKING CHANGE: `View#addChildren` and `View#removeChildren` methods became `#registerChildren` and `#deregisterChildren`.

BREAKING CHANGE:  The DOM structure of the `StickyPanelView` has changed along with the class names. Please refer to the component documentation to learn more.
@mlewand mlewand transferred this issue from ckeditor/ckeditor5-ui Oct 9, 2019
@mlewand mlewand added this to the iteration 13 milestone Oct 9, 2019
@mlewand mlewand added status:confirmed type:bug This issue reports a buggy (incorrect) behavior. package:ui labels Oct 9, 2019
@oleq oleq mentioned this issue Oct 11, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@oleq oleq

Labels
package:ui type:bug This issue reports a buggy (incorrect) behavior.
Projects
None yet
Milestone
iteration 13
Development

Successfully merging a pull request may close this issue.

T/262: Implemented View#render method ckeditor/ckeditor5-ui
3 participants
@oskarwrobel @oleq @mlewand