Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Class–controlling property name should be the same in all components #5489

Closed
oleq opened this issue Oct 15, 2018 · 0 comments · Fixed by ckeditor/ckeditor5-ui#456
Closed

Class–controlling property name should be the same in all components #5489

oleq opened this issue Oct 15, 2018 · 0 comments · Fixed by ckeditor/ckeditor5-ui#456
Assignees
@jodator
Labels
package:ui type:bug This issue reports a buggy (incorrect) behavior.
Milestone
iteration 22

Comments

@oleq
Copy link
Member

oleq commented Oct 15, 2018

ATM they are not the same:
@jodator jodator self-assigned this Dec 11, 2018
oleq referenced this issue in ckeditor/ckeditor5-ui Dec 19, 2018
@oleq
Merge pull request #456 from ckeditor/t/450
b9b68c6 
Other: The "class" property should control the DOM class attribute in all UI components. Closes #450.

BREAKING CHANGE: The `BallonPanelView#className` property was renamed to `#class`.
BREAKING CHANGE: The `ToolbarView#className` property was renamed to `#class`.
oleq referenced this issue Dec 19, 2018
@oleq
Merge pull request #1407 from ckeditor/t/ckeditor-ui/450
2aaa60d 
Docs: Aligned the UI library guide to the convention in which the observable "class" property controls the DOM class attribute (see ckeditor/ckeditor5-ui#450).
oleq referenced this issue in ckeditor/ckeditor5-theme-lark Dec 19, 2018
@oleq
Merge pull request #212 from ckeditor/t/ckeditor5-ui/450
a91de02 
Tests: Aligned the manual test to the changes in the `ToolbarView` class API (see ckeditor/ckeditor5-ui#450).
@mlewand mlewand transferred this issue from ckeditor/ckeditor5-ui Oct 9, 2019
@mlewand mlewand added this to the iteration 22 milestone Oct 9, 2019
@mlewand mlewand added status:confirmed type:bug This issue reports a buggy (incorrect) behavior. package:ui labels Oct 9, 2019
@jodator jodator mentioned this issue Oct 11, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jodator jodator

Labels
package:ui type:bug This issue reports a buggy (incorrect) behavior.
Projects
None yet
Milestone
iteration 22
Development

Successfully merging a pull request may close this issue.

Use class as class-controlling property of ui components. ckeditor/ckeditor5-ui
3 participants
@jodator @oleq @mlewand