Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ImageUploadButton should be disabled when uploadCommand is disabled #2815

Closed
oskarwrobel opened this issue Jul 11, 2017 · 0 comments · Fixed by ckeditor/ckeditor5-upload#44
Closed

ImageUploadButton should be disabled when uploadCommand is disabled #2815

oskarwrobel opened this issue Jul 11, 2017 · 0 comments · Fixed by ckeditor/ckeditor5-upload#44
Assignees
@oskarwrobel
Labels
package:upload type:bug This issue reports a buggy (incorrect) behavior.
Milestone
iteration 11

Comments

@oskarwrobel
Copy link
Contributor

When the editor is in read-only mode and UploadCommand is disabled ImageUploadButton stays enabled.
@oskarwrobel oskarwrobel self-assigned this Jul 11, 2017
pjasiun referenced this issue in ckeditor/ckeditor5-upload Jul 12, 2017
Merge pull request #44 from ckeditor/t/43
ba6de66 
Fix: Bound ImageUploadButton#isEnabled to ImageUploadCommand#isEnabled. Closes #43.
@mlewand mlewand transferred this issue from ckeditor/ckeditor5-upload Oct 9, 2019
@mlewand mlewand added this to the iteration 11 milestone Oct 9, 2019
@mlewand mlewand added status:confirmed type:bug This issue reports a buggy (incorrect) behavior. package:upload labels Oct 9, 2019
@oskarwrobel oskarwrobel mentioned this issue Oct 11, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@oskarwrobel oskarwrobel

Labels
package:upload type:bug This issue reports a buggy (incorrect) behavior.
Projects
None yet
Milestone
iteration 11
Development

Successfully merging a pull request may close this issue.

Bound ImageUploadButton#isEnabled to ImageUploadCommand#isEnabled. ckeditor/ckeditor5-upload
2 participants
@oskarwrobel @mlewand