Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Insert after the block if the caret is at the very end of the block #2789

Closed
pjasiun opened this issue Apr 5, 2017 · 1 comment · Fixed by ckeditor/ckeditor5-upload#28
Closed

Insert after the block if the caret is at the very end of the block #2789

pjasiun opened this issue Apr 5, 2017 · 1 comment · Fixed by ckeditor/ckeditor5-upload#28
Labels
package:upload type:bug This issue reports a buggy (incorrect) behavior.
Milestone
iteration 11

Comments

@pjasiun
Copy link

pjasiun commented Apr 5, 2017

We decided that to prevent breaking the block, the uploading image will be inserted before it. The exception is the situation when the caret is at the very end of the block. Then image should be inserted after the block.

Now the image is always inserted before the block.
@Reinmar
Copy link
Member

Reinmar commented May 9, 2017

I changed the type of this ticket to a bug to give it a bit higher priority.

@szymonkups szymonkups self-assigned this May 10, 2017
Reinmar referenced this issue in ckeditor/ckeditor5-upload May 11, 2017
@Reinmar
Merge pull request #28 from ckeditor/t/7
70742f9 
Fix: Image will be inserted after the block if the selection is placed at the block's end. Closes #7.
@mlewand mlewand transferred this issue from ckeditor/ckeditor5-upload Oct 9, 2019
@mlewand mlewand added this to the iteration 11 milestone Oct 9, 2019
@mlewand mlewand added status:confirmed type:bug This issue reports a buggy (incorrect) behavior. package:upload labels Oct 9, 2019
@szymonkups szymonkups mentioned this issue Oct 11, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
package:upload type:bug This issue reports a buggy (incorrect) behavior.
Projects
None yet
Milestone
iteration 11
Development

Successfully merging a pull request may close this issue.

Inserting image after the block when selection is placed at its end ckeditor/ckeditor5-upload
4 participants
@Reinmar @pjasiun @szymonkups @mlewand