-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[iOS] Sticky toolbar disappears after scrolling editor on iPad #1280
Comments
Possibly connected to the https://github.com/ckeditor/ckeditor5-ui/issues/405. |
That's caused by the issues described in ckeditor/ckeditor5-design#149 – it's Safari's quirky viewport mechanics. |
Exactly. I was thinking recently that maybe we should disable the stickiness in iOS. The toolbar would be static but predictable. What we have now definitely looks like a bug to the users. |
That's an interesting idea. It would be irritating if you edit a long content, then you'd have to jump up all the time. But it'd indeed help in case of shorter texts. |
@Reinmar I'm having this annoying behaviour. Related to iOS's viewport I assume |
That's a combination of two problems – https://bugs.webkit.org/show_bug.cgi?id=191204 and an issue that I've been recently discussing on W3C TPAC which is a general lack of control over the native UI which, in this crowded space, makes it rather impossible to create your own UI in a reliable way. For instance, the fact that the caret ends below the toolbar, even though it's generally caused by the viewport issues, shows also our lack of ability to tell the browser where it should not position the selection on the screen or vice versa – where we should not position our UI. IDK if you consider this a viable solution but not using the sticky toolbar would help now. You could use the decoupled editor and control the toolbar yourself. Perhaps, you'd be able to come up with a better location or placing logic for it. |
I created a PoC of a solution to address this issue. The code is in https://github.com/ckeditor/ckeditor5/compare/ck/1280-sticky-toolbar-visual-viewport?expand=1.
RPReplay_Final1664547784.MP4
RPReplay_Final1664548363.MP4
|
There has been no activity on this issue for the past year. We've marked it as stale and will close it in 30 days. We understand it may be relevant, so if you're interested in the solution, leave a comment or reaction under this issue. |
We've closed your issue due to inactivity over the last year. We understand that the issue may still be relevant. If so, feel free to open a new one (and link this issue to it). |
Is this a bug report or feature request? (choose one)
🐞 Bug report
💻 Version of CKEditor
11.0.1
📋 Steps to reproduce
✅ Expected result
The sticky toolbar is visible.
❎ Actual result
The sticky toolbar doesn't show up.
📃 Other details that might be useful
It works fine when iPad's orientation is portrait.
The text was updated successfully, but these errors were encountered: