Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pasting table from Google Sheets creates table with 0px width #14122

Closed
filipsobol opened this issue May 12, 2023 · 2 comments
Closed

Pasting table from Google Sheets creates table with 0px width #14122

filipsobol opened this issue May 12, 2023 · 2 comments
Labels
resolution:invalid This issue is invalid (e.g. reports a non-existent bug or a by-design behavior). squad:core Issue to be handled by the Core team. type:bug This issue reports a buggy (incorrect) behavior.

Comments

@filipsobol
Copy link
Member

This is related to the bug which was partially fixed in #13915.

📝 Provide detailed reproduction steps (if any)

  1. Change the htmlSupport object in ghs-all-features.js test to:
    allow: [
      {
        name: /^(table|thead|tbody|td|th|tr|col|colgroup)$/,
        styles: true,
        attributes: true,
        classes: true
      }
    ]
    
  2. Run yarn manual -f html-support and open the ghs-all-features test.
  3. Select and copy few cells from Google Sheets to paste them into the editor.

✔️ Expected result

Table should be properly pasted.

❌ Actual result

Table has 0px width.

Screenshot_20230512_091247

❓ Possible solution

This bug is already fixed in the PasteFromOffice plugin (see links above), so part of it may need to be ported back to the Table plugin.

📃 Other details

  • Browser: Firefox 113.0
  • OS: Linux

If you'd like to see this fixed sooner, add a 👍 reaction to this post.

@filipsobol filipsobol added type:bug This issue reports a buggy (incorrect) behavior. squad:core Issue to be handled by the Core team. labels May 12, 2023
@Witoso
Copy link
Member

Witoso commented May 12, 2023

I'm torn, it's the data that we get from Google, want to make it better? Enable PasteFromOffice which AFAIK is a part of all builds and website demos and docs. At the same time someone may not have this plugin 🤔

@filipsobol filipsobol added the release:potential-blocker This issue potentially blocks the upcoming release (should be checked). label May 12, 2023
@pomek pomek removed the release:potential-blocker This issue potentially blocks the upcoming release (should be checked). label May 12, 2023
@filipsobol
Copy link
Member Author

We discussed this internally and decided that PasteFromOffice is required plugin when working with data from Office, Google Docs and Google Sheets. This bug is fixed in this plugin, so we are closing this issue.

@Reinmar Reinmar added the resolution:invalid This issue is invalid (e.g. reports a non-existent bug or a by-design behavior). label May 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
resolution:invalid This issue is invalid (e.g. reports a non-existent bug or a by-design behavior). squad:core Issue to be handled by the Core team. type:bug This issue reports a buggy (incorrect) behavior.
Projects
None yet
Development

No branches or pull requests

4 participants