-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Separate configuration for styles in ol
and ul
list properties
#15554
Comments
ol
and ul
list propertiesol
and ul
list properties
Yes! This would be great. The "type" attribute on unordered lists is deprecated and we don't want our users to use it, but we do want them to use the attribute on ordered lists, where it has semantic meaning. This is one of the remaining blockers for us to upgrade ~1000 sites to CKEditor 5. |
One crucial part of information is missing from this issue: this is a hard blocker for That issue has MANY followers; 46 right now. @bkosborne has a crazy number of sites blocked on this, but for context: Drupal 9/10 have hundreds of thousands of sites using them and the highest number of followers for a Drupal core issue that I've EVER seen is ~250. >100 followers gets you easily in the top 0.1% of issues. The count of 46 gets you in the top 1% probably, at minimum in the top 2%. @Witoso This seems so bafflingly trivial to add … can you perhaps point to some prior art so that @bkosborne can contribute the changes himself? |
While I understand the impact, I wouldn't judge this as trivial (maybe in LoCs). We need to create a non-breaking API change in one of the most used features. As of now, I don't have manpower to push this, but I will try to add it as a subissue to a current larger initiative. AFAICS, it was ecosystem's decision to block this based on the non-separate config, as the I'm also not sure where I could point, tactical cc to @arkflpc as I think you participated in the implementation. |
It seems to be a quite small ticket, both in implementation and API design. |
Ok, let's discuss it, and I will ping you @wimleers and @bkosborne. |
Great! Appreciate it :)
This is not just "a decision" as if it's subjective and could've gone either way without consequences. Without this, it's an objective fact that we'd make some use cases impossible.
Not breaking BC should be trivial:
can remain supported, just also allow:
(and make that the new internal representation, just map |
📝 Provide a description of the improvement
Add a possibility to configure the styles of list properties separately. For example, allow content editors to choose for list of styles for
ol
but not forul
's. Currently, the configuration affects both.Requested by Drupal.
📃 Other details
If you'd like to see this improvement implemented, add a 👍 reaction to this post.
The text was updated successfully, but these errors were encountered: