Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redesign on state in menu and dropdowns #16572

Closed
Mati365 opened this issue Jun 14, 2024 · 1 comment · Fixed by #16573
Closed

Redesign on state in menu and dropdowns #16572

Mati365 opened this issue Jun 14, 2024 · 1 comment · Fixed by #16573
Assignees
Labels
type:feature This issue reports a feature request (an idea for a new functionality or a missing option).

Comments

@Mati365
Copy link
Member

Mati365 commented Jun 14, 2024

📝 Provide a description of the new feature

During the development of accessibility (A11y) improvements for menubar and other dropdowns, there was a discussion about how to represent the "on" state in these controls. Currently, the "on" state is not visually represented in the menubar, but in dropdowns, it appears as a "filled-in" blue state[1]. However, this doesn't look great in the menu. As a solution, the team decided to use checkbox marks[2] to indicate whether an option is selected or not.

[1] Old filled in state:
Old filled state

[1] New checkbox menu state:
obraz

@Mati365 Mati365 added the type:feature This issue reports a feature request (an idea for a new functionality or a missing option). label Jun 14, 2024
@Mati365 Mati365 self-assigned this Jun 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:feature This issue reports a feature request (an idea for a new functionality or a missing option).
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants