Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code conversion is too greedy. #17789

Closed
pszczesniak opened this issue Jan 21, 2025 · 0 comments · Fixed by #17791
Closed

Code conversion is too greedy. #17789

pszczesniak opened this issue Jan 21, 2025 · 0 comments · Fixed by #17791
Assignees
Labels
package:basic-styles squad:core Issue to be handled by the Core team. type:bug This issue reports a buggy (incorrect) behavior.

Comments

@pszczesniak
Copy link
Contributor

📝 Provide detailed reproduction steps (if any)

  1. Source HTML: <p style="word-wrap: break-word">foo bar</p>
  2. Will be converted into: <p><code>foo bar</code></p>

✔️ Expected result

style="word-wrap: break-word" should not be converted into <code> tag

❌ Actual result

style="word-wrap: break-word" is now converted into <code> tag

❓ Possible solution

upcastAlso should be removed:

upcastAlso: {
styles: {
'word-wrap': 'break-word'
}
}

📃 Other details

  • Browser: …
  • OS: …
  • First affected CKEditor version: …
  • Installed CKEditor plugins: …

If you'd like to see this fixed sooner, add a 👍 reaction to this post.

@pszczesniak pszczesniak added package:basic-styles squad:core Issue to be handled by the Core team. type:bug This issue reports a buggy (incorrect) behavior. labels Jan 21, 2025
@pszczesniak pszczesniak self-assigned this Jan 21, 2025
@CKEditorBot CKEditorBot added the status:in-progress Set automatically when an issue lands in the "In progress" column. We are working on it. label Jan 21, 2025
@CKEditorBot CKEditorBot removed the status:in-progress Set automatically when an issue lands in the "In progress" column. We are working on it. label Jan 21, 2025
@CKEditorBot CKEditorBot added this to the iteration 82 milestone Jan 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package:basic-styles squad:core Issue to be handled by the Core team. type:bug This issue reports a buggy (incorrect) behavior.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants