-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Accessibility of the tables UI #3184
Comments
|
I'd like to see the table button open a dialog in which you can specify "rows" and "columns" in text inputs. |
What do you mean by
|
|
Check out https://github.com/ckeditor/ckeditor5-table/issues/22.
Not sure what you mean here. You'd expect us to drop the balloon completely or move its content to the main toolbar in certain situations? If the later, what would it look/work like? |
Moving these buttons to the main toolbar seems to be an overkill. The real issue is that there's no way to focus widget toolbar and this should be addressed.
@mlewand Do you think we can work on this anytime soon? |
I agree with @oleq here. There's a reason why we placed these buttons in a separate toolbar. Our goal is to avoid cluttering the UI (in this case main toolbar) with extra buttons if possible. That's why we have these context-based additional balloon toolbars. This particular issue should be simply fixed by providing a way to move the focus into the balloon toolbar (which we need anyway, because it will also apply to the image toolbar). My first idea is to make our As for expected ETA I don't have any at this moment. But please, add a 👍 reaction to the main post of this issue so that we can see that community is interested in this improvement. |
cc @Comandeer |
Ok, but @juleskuehn point is still valid about keyboard only navigation remains a problem, right? If it is fixed, then perhaps we need a bit more navigation as I couldn't figure out how to make a cell a heading without using my mouse. This may well be a problem for Drupal's adoption of CKEditor 5. |
This is a related issue #9782 |
I think this would be a better model https://accessibilitycluster.com/main-results/table-creator |
This issue listed a few different bugs. All of the problems have been subtracted to dedicated issues and can be tracked independently. |
@mlewand Can you please link those issues? 🙏 (So I know how to update https://www.drupal.org/project/drupal/issues/3283800 😊 ) |
@wimleers added references to this issue in subtasks 👍 |
ATM
an error is thrown when navigating to the insertion panel https://github.com/ckeditor/ckeditor5-table/issues/30,there's no strategy as to how the a11y should work in the panel; probably the arrow keys will control the geometry of the grid but we also need to understand how to announce that, (this is covered by Add keyboard support for insert table dropdown #3176)there's no way to focus the table toolbar using the keyboard and use its features (will be solved by Unable to focus balloon toolbars (image toolbar, table toolbar etc) #5146)If you'd like to see this feature implemented, add 👍 to this post.
The text was updated successfully, but these errors were encountered: