Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accessibility of the tables UI #3184

Closed
oleq opened this issue Jun 5, 2018 · 16 comments
Closed

Accessibility of the tables UI #3184

oleq opened this issue Jun 5, 2018 · 16 comments
Labels
domain:accessibility This issue reports an accessibility problem. domain:ui/ux This issue reports a problem related to UI or UX. package:table resolution:duplicate This issue is a duplicate of another issue and was merged into it. squad:features Issue to be handled by the Features team. support:2 An issue reported by a commercially licensed client. type:improvement This issue reports a possible enhancement of an existing feature.

Comments

@oleq
Copy link
Member

oleq commented Jun 5, 2018

ATM


If you'd like to see this feature implemented, add 👍 to this post.

@jodator
Copy link
Contributor

jodator commented Jun 11, 2018

@jodator jodator closed this as completed Jun 11, 2018
@jodator jodator reopened this Jun 11, 2018
@juleskuehn
Copy link

I'd like to see the table button open a dialog in which you can specify "rows" and "columns" in text inputs.
The other issues can be resolved by including the pop-up table toolbar buttons in the main toolbar, correct?

@oleq
Copy link
Member Author

oleq commented Jul 23, 2019

What do you mean by

pop-up table toolbar buttons

@juleskuehn ?

@juleskuehn
Copy link

Screenshot of pop-up table toolbar buttons
@oleq Floating menu that appears when a table is focused

@oleq
Copy link
Member Author

oleq commented Jul 24, 2019

I'd like to see the table button open a dialog in which you can specify "rows" and "columns" in text inputs.

Check out https://github.com/ckeditor/ckeditor5-table/issues/22.

The other issues can be resolved by including the pop-up table toolbar buttons in the main toolbar, correct?

Not sure what you mean here. You'd expect us to drop the balloon completely or move its content to the main toolbar in certain situations? If the later, what would it look/work like?

@juleskuehn
Copy link

The buttons in the pop-up toolbar are not keyboard accessible, but those buttons can already be included in the main toolbar, where they are accessible. This is a workaround I'm using to make these features accessible (although I think a keyboard-only user would still be frustrated by the existence of the inaccessible pop-up menu). I don't have a solution for the pop-up menu other than adding a keyboard shortcut to focus pop-up menus. I'm just bringing it up for discussion.

Two remaining issues.

  1. Keyboard focusing the main toolbar (via Alt+F10) does not dismiss the pop-up toolbar, which obscures the dropdown from the row / column buttons:
    image
  2. When "Header row" or "Header column" are toggled, focus moves back to the content editing area, but the drop-down menu containing the toggle switch remains onscreen.
    image

@oleq
Copy link
Member Author

oleq commented Jul 24, 2019

Moving these buttons to the main toolbar seems to be an overkill. The real issue is that there's no way to focus widget toolbar and this should be addressed.

there's no way to focus the table toolbar using the keyboard and use its features (a twin of ckeditor5-image issue, we need a general strategy)

@mlewand Do you think we can work on this anytime soon?

@mlewand
Copy link
Contributor

mlewand commented Jul 24, 2019

I agree with @oleq here. There's a reason why we placed these buttons in a separate toolbar.

Our goal is to avoid cluttering the UI (in this case main toolbar) with extra buttons if possible. That's why we have these context-based additional balloon toolbars.

This particular issue should be simply fixed by providing a way to move the focus into the balloon toolbar (which we need anyway, because it will also apply to the image toolbar). My first idea is to make our alt + f10 to cycle across all available toolbars (and alt + shift + f10 in reverse direction).

As for expected ETA I don't have any at this moment. But please, add a 👍 reaction to the main post of this issue so that we can see that community is interested in this improvement.

@oleq
Copy link
Member Author

oleq commented Jul 29, 2019

This particular issue should be simply fixed by providing a way to move the focus into the balloon toolbar (which we need anyway, because it will also apply to the image toolbar). My first idea is to make our alt + f10 to cycle across all available toolbars (and alt + shift + f10 in reverse direction).

cc @Comandeer

@mlewand mlewand transferred this issue from ckeditor/ckeditor5-table Oct 9, 2019
@mlewand mlewand added this to the backlog milestone Oct 9, 2019
@mlewand mlewand added domain:accessibility This issue reports an accessibility problem. domain:ui/ux This issue reports a problem related to UI or UX. module:ux type:improvement This issue reports a possible enhancement of an existing feature. package:table labels Oct 9, 2019
@Reinmar Reinmar changed the title Accessibility of the UI Accessibility of the tables UI Nov 26, 2019
@Reinmar Reinmar removed the module:ux label Jan 15, 2020
@mgifford
Copy link

Ok, but @juleskuehn point is still valid about keyboard only navigation remains a problem, right? If it is fixed, then perhaps we need a bit more navigation as I couldn't figure out how to make a cell a heading without using my mouse.

This may well be a problem for Drupal's adoption of CKEditor 5.

@mgifford
Copy link

This is a related issue #9782

@mgifford
Copy link

I think this would be a better model https://accessibilitycluster.com/main-results/table-creator

@martynawierzbicka martynawierzbicka added the support:2 An issue reported by a commercially licensed client. label Aug 31, 2021
@pomek pomek removed this from the backlog milestone Feb 21, 2022
@wimleers
Copy link

Many aspects of this overlap with #2000 and #3215 AFAICT

@mlewand
Copy link
Contributor

mlewand commented Jun 10, 2022

This issue listed a few different bugs. All of the problems have been subtracted to dedicated issues and can be tracked independently.

@mlewand mlewand closed this as completed Jun 10, 2022
@mlewand mlewand added squad:features Issue to be handled by the Features team. resolution:duplicate This issue is a duplicate of another issue and was merged into it. labels Jun 10, 2022
@wimleers
Copy link

wimleers commented Jun 14, 2022

@mlewand Can you please link those issues? 🙏

(So I know how to update https://www.drupal.org/project/drupal/issues/3283800 😊 )

@mlewand
Copy link
Contributor

mlewand commented Jun 14, 2022

@wimleers added references to this issue in subtasks 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
domain:accessibility This issue reports an accessibility problem. domain:ui/ux This issue reports a problem related to UI or UX. package:table resolution:duplicate This issue is a duplicate of another issue and was merged into it. squad:features Issue to be handled by the Features team. support:2 An issue reported by a commercially licensed client. type:improvement This issue reports a possible enhancement of an existing feature.
Projects
None yet
Development

No branches or pull requests

9 participants