Features should set their keystrokes through the keystroke handler #339
Labels
resolution:invalid
This issue is invalid (e.g. reports a non-existent bug or a by-design behavior).
type:improvement
This issue reports a possible enhancement of an existing feature.
type:task
This issue reports a chore (non-production change) and other types of "todos".
This is an extension of https://github.com/ckeditor/ckeditor5-core/issues/20.
Features like the enter key, delete and list (tab to indent) listen on the view. This makes it harder to change keystroke which triggers them. In CKEditor 4 you were able to define that the enter command is triggered by any key. Sometimes this may be useful. Perhaps not this case, but I can see more people redefining indent/outdent keystrokes.
Edit: Please read #340 for more details.
Another thing to consider is that perhaps actions which will have their associatedbeforeinput
type should not be set through the keystroke handler. This, in the future, would be a serious problem, because we'd need to stop listening to the keystroke and start listening to thebeforeinput
event (you can do both at the same time). After all, if someone wants to change some key behaviour, then the keystroke handler will always be available (keydown
should be fired first).tl;dr:1. Keystrokes which have their associatedbeforeinput
type should be handled directly through theview#keydown
event.2. All other keystrokes should be handled through the keystroke handler.The text was updated successfully, but these errors were encountered: