Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Markers in the document fragment #4171

Open
pjasiun opened this issue Sep 1, 2017 · 2 comments
Open

Markers in the document fragment #4171

pjasiun opened this issue Sep 1, 2017 · 2 comments
Labels
package:engine support:2 An issue reported by a commercially licensed client.

Comments

@pjasiun
Copy link

pjasiun commented Sep 1, 2017

Because we have different API to modify the document and different API to modify document fragment (see https://github.com/ckeditor/ckeditor5-engine/issues/858) markers on the document fragment does not work well. It is a problem when you want to handle for instance markers copy and paste.

We should rethink how markers on the document fragment could work after we unify the API to modify the tree model.

@oskarwrobel oskarwrobel self-assigned this Feb 7, 2018
@oskarwrobel oskarwrobel removed their assignment Feb 22, 2018
@pjasiun
Copy link
Author

pjasiun commented Mar 2, 2018

Since https://github.com/ckeditor/ckeditor5-engine/issues/858 is closed now, we can remove the special mechanism to handle markers in document fragments/upcast, including markers property in the document fragment class:
https://github.com/ckeditor/ckeditor5-engine/blob/2462d27dee6029161853c7f0bbae8953049bd768/src/model/documentfragment.js#L39

@mlewand mlewand transferred this issue from ckeditor/ckeditor5-engine Oct 9, 2019
@mlewand mlewand added this to the unknown milestone Oct 9, 2019
@lslowikowska lslowikowska added the support:2 An issue reported by a commercially licensed client. label Dec 22, 2020
@Reinmar
Copy link
Member

Reinmar commented Aug 10, 2021

Specific issue for the copy/cut/drag/drop of markers: #10331

@pomek pomek removed this from the unknown milestone Feb 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package:engine support:2 An issue reported by a commercially licensed client.
Projects
None yet
Development

No branches or pull requests

6 participants