Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove EnterObserver #4557

Closed
Reinmar opened this issue Oct 19, 2016 · 3 comments
Closed

Remove EnterObserver #4557

Reinmar opened this issue Oct 19, 2016 · 3 comments
Labels
package:enter resolution:invalid This issue is invalid (e.g. reports a non-existent bug or a by-design behavior). status:discussion type:task This issue reports a chore (non-production change) and other types of "todos".

Comments

@Reinmar
Copy link
Member

Reinmar commented Oct 19, 2016

As agreed in #340 (somewhere deep that hole) such observers make no sense, since they duplicate already existing event. The extension point should be elsewhere (command or the standard keydown event or keystroke handler).
@Reinmar
Copy link
Member Author

Reinmar commented Oct 19, 2016

And together with this ticket we should make Enter feature use the keystroke handler.

@Reinmar
Copy link
Member Author

Reinmar commented Feb 9, 2017

I'm a bit unsure about this now: https://github.com/ckeditor/ckeditor5-typing/issues/56#issuecomment-278607790.

@Reinmar
Copy link
Member Author

Reinmar commented May 4, 2018

OK, I made the decision. Let's leave the EnterObserver. Explanation can be found here: https://github.com/ckeditor/ckeditor5-enter/issues/2#issuecomment-386607029

@Reinmar Reinmar closed this as completed May 4, 2018
@mlewand mlewand transferred this issue from ckeditor/ckeditor5-enter Oct 9, 2019
@mlewand mlewand added resolution:invalid This issue is invalid (e.g. reports a non-existent bug or a by-design behavior). status:discussion type:task This issue reports a chore (non-production change) and other types of "todos". package:enter labels Oct 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
package:enter resolution:invalid This issue is invalid (e.g. reports a non-existent bug or a by-design behavior). status:discussion type:task This issue reports a chore (non-production change) and other types of "todos".
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Reinmar @mlewand