Postfixer should remove the whole mention when it's build from two+ text nodes

[Reinmar]

[jodator]

I was thinking about such cases and forgot to create a follow-up for this. I wonder how mention should behave when someone would try to style the mention?

Right now it allows to style part of a mention but shouldn't we disallow this? Enforce whole text node to be selected when applying attribute?

[Reinmar]

It's tricky... The most problematic part is that in the output you'll get a split span, so processing such content would be hard.

We've got two options:

• prevent applying styling to part of a mention by either extending the style to the whole mention or not applying it,
• remove the mention when part of it was styled.

The latter seems easier.

Do we have some examples how others approached this?

[jodator]

Quick check:

Slack breaks mention into "partial match" mention:

Github extends breaks bold:
foo @Rein**mar bar**: foo @Reinmar bar (different user is mentioned)

Gitlab - broken mention:

Twitter, Facebook - no styling no problem

[Reinmar]

I'd go with an easier solution for now. Which, IMO, may be to remove the mention. But if extending the style is easy to implement as well, then I'm fine with it too.

[oleq]

I agree, styling a part of the mention should remove that part from the mention. We can go with something more sophisticated in the future but for now, this will suffice.

[jodator]

should remove that part from the mention

To be precise - it should remove whole mentino as we do not allow partial mentions in other cases (ie typing).

[oleq]

Partial removal makes more sense IMO but I guess it's harder to implement, right?

[jodator]

Partial removal makes more sense IMO but I guess it's harder to implement, right?

We agreed that mention is full ie @jodator not @jodat so in that spirit we remove partial mentions.