Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rect and scroll utilities should support multi window scenarios (aka iframe support) #4967

Closed
Reinmar opened this issue Aug 15, 2017 · 1 comment · Fixed by ckeditor/ckeditor5-utils#183
Closed

Rect and scroll utilities should support multi window scenarios (aka iframe support) #4967

Reinmar opened this issue Aug 15, 2017 · 1 comment · Fixed by ckeditor/ckeditor5-utils#183
Assignees
@oleq
Labels
package:utils type:feature This issue reports a feature request (an idea for a new functionality or a missing option).
Milestone
iteration 12

Comments

@Reinmar
Copy link
Member

Reinmar commented Aug 15, 2017

See:
@Reinmar Reinmar changed the title Rect and scroll utilities should support multi window scenarios Rect and scroll utilities should support multi window scenarios (aka iframe support) Aug 15, 2017
@oleq
Copy link
Member

oleq commented Sep 8, 2017

This issue should get a higher priority since we use iframes in the documentation (red border). Upon changing the heading, viewDocument.scrollToTheSelection is called and it scrolls the entire web page despite the fact that the selection and heading are actually visible to the user. It's super-annoying.

kapture 2017-09-08 at 10 55 39

@oleq oleq self-assigned this Sep 14, 2017
Reinmar referenced this issue in ckeditor/ckeditor5-utils Sep 21, 2017
@Reinmar
Merge pull request #183 from ckeditor/t/175
a5c27ea 
Feature: Scrolling DOM utilities should support multi-window scenarios. Closes #175.
oleq referenced this issue in ckeditor/ckeditor5-engine Sep 21, 2017
@oleq
Tests: Fixed failing ing Document#scrollToTheSelection tests after ck…
3d7f507 
…editor/ckeditor5-utils#175.
oleq referenced this issue in ckeditor/ckeditor5-ui Sep 21, 2017
@oleq
Tests: Fixed failing BalloonPanelView tests after ckeditor/ckeditor5-…
2bea29c 
…utils#175.
@mlewand mlewand transferred this issue from ckeditor/ckeditor5-utils Oct 9, 2019
@mlewand mlewand added this to the iteration 12 milestone Oct 9, 2019
@mlewand mlewand added status:confirmed type:feature This issue reports a feature request (an idea for a new functionality or a missing option). package:utils labels Oct 9, 2019
@oleq oleq mentioned this issue Oct 11, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@oleq oleq

Labels
package:utils type:feature This issue reports a feature request (an idea for a new functionality or a missing option).
Projects
None yet
Milestone
iteration 12
Development

Successfully merging a pull request may close this issue.

t/175: Scrolling DOM utilities should support multi–window scenarios ckeditor/ckeditor5-utils
3 participants
@Reinmar @oleq @mlewand