Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Empty figcaption needs placeholder #5075

Closed
oleq opened this issue Mar 13, 2017 · 1 comment · Fixed by ckeditor/ckeditor5-image#82
Closed

Empty figcaption needs placeholder #5075

oleq opened this issue Mar 13, 2017 · 1 comment · Fixed by ckeditor/ckeditor5-image#82
Labels
domain:ui/ux This issue reports a problem related to UI or UX. package:image type:improvement This issue reports a possible enhancement of an existing feature.
Milestone
iteration 9

Comments

@oleq
Copy link
Member

oleq commented Mar 13, 2017

Because this strange space beneath the focused image

image

tells the user nothing about what it is and what they could use it for. In fact, it kinda looks like a bug because, unlike v4, the nested editable does not have a clear outline.
image

Some faded out placeholder text like "Caption of this image", which disappears once it gains focus would do the trick.
@Reinmar
Copy link
Member

Reinmar commented Mar 13, 2017

Requires: https://github.com/ckeditor/ckeditor5-engine/issues/857.

@szymonkups szymonkups self-assigned this Mar 28, 2017
Reinmar referenced this issue in ckeditor/ckeditor5-image Mar 30, 2017
@Reinmar
Merge pull request #82 from ckeditor/t/71
3818544 
Feature: Added "Enter caption here" placeholders to empty image captions. Closes #71.
@mlewand mlewand transferred this issue from ckeditor/ckeditor5-image Oct 9, 2019
@mlewand mlewand added this to the iteration 9 milestone Oct 9, 2019
@mlewand mlewand added the domain:ui/ux This issue reports a problem related to UI or UX. label Oct 9, 2019
@mlewand mlewand added module:ux type:improvement This issue reports a possible enhancement of an existing feature. package:image labels Oct 9, 2019
@szymonkups szymonkups mentioned this issue Oct 11, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
domain:ui/ux This issue reports a problem related to UI or UX. package:image type:improvement This issue reports a possible enhancement of an existing feature.
Projects
None yet
Milestone
iteration 9
Development

Successfully merging a pull request may close this issue.

T/71 Placeholder for image caption. ckeditor/ckeditor5-image
4 participants
@Reinmar @oleq @szymonkups @mlewand