Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect position of ContextualToolbar for image caption #5408

Closed
oskarwrobel opened this issue Sep 20, 2017 · 1 comment · Fixed by ckeditor/ckeditor5-ui#309
Closed

Incorrect position of ContextualToolbar for image caption #5408

oskarwrobel opened this issue Sep 20, 2017 · 1 comment · Fixed by ckeditor/ckeditor5-ui#309
Assignees
@oleq
Labels
package:ui type:bug This issue reports a buggy (incorrect) behavior.
Milestone
iteration 12

Comments

@oskarwrobel
Copy link
Contributor

If you want to apply some styles to the image caption and you select this caption by a double click then CT goes to some weird place.

sep-20-2017 20-40-22

This might be the same issue as https://github.com/ckeditor/ckeditor5-ui/issues/180#issuecomment-290370751.
@oleq
Copy link
Member

oleq commented Sep 21, 2017

@oskarwrobel Please take a look at the fix that I proposed in ckeditor/ckeditor5-ui#309. I'm wondering if it may break anything... WDYT?

@oleq oleq self-assigned this Sep 21, 2017
oskarwrobel referenced this issue in ckeditor/ckeditor5-ui Sep 21, 2017
@oskarwrobel
Merge pull request #309 from ckeditor/t/308
00b701b 
Fix: `ContextualToolbar` should not be positioned to a zero–width DOM rect when invoked for a multi-line forward selection. Closes #308.
@mlewand mlewand transferred this issue from ckeditor/ckeditor5-ui Oct 9, 2019
@mlewand mlewand added this to the iteration 12 milestone Oct 9, 2019
@mlewand mlewand added status:confirmed type:bug This issue reports a buggy (incorrect) behavior. package:ui labels Oct 9, 2019
@oleq oleq mentioned this issue Oct 11, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@oleq oleq

Labels
package:ui type:bug This issue reports a buggy (incorrect) behavior.
Projects
None yet
Milestone
iteration 12
3 participants
@oskarwrobel @oleq @mlewand