-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dropdown panel should not not be cut off when the editor is inside in an overflow: hidden host #5514
Comments
Can it be easily moved to the document collection? |
I created a similar PoC one day to solve some other issue (don't remember which one) and the biggest issue was that the panel must follow the toolbar when things are scrolled, etc. and there's was some positioning lag we decided was unacceptable. Now I remember, I researched the horizontally scrollable toolbar for mobiles, gonna quote myself: [...]
|
It's so sad. In other words – there's no viable solution at the moment. Not only we'd have to rewrite the dropdowns but also toolbars to use exactly the same positioning mechanism. Am I right that the only solution, for now, is to not use |
Not really. We can improve the panel positioning algorithm. It can detect not only the viewport boundaries but also ancestors with |
Issue seems a bit old and closed, but I still have the problem. Should we reopen this one or generate a new ticket I don't know but only thing i can tell that the approach by trying to understand the overflow:hidden ancestors won't work. As my condition it didn't work, It have a grid, grid-item with overflow-hidden and a flex-box stretches the content. Solution should be applied on a bit more generic way. And I'm sure that it will be more easier than understanding the ancestors. Create an overlay element on top of everything. for example a div element with position static at the end of body and locate your dropdowns inside that according to the reference elements .getBoundingClientRect().top and left and of course width. Than you'll never fall in to dropdown crops. |
the same problem appears when CKEditor is rendered inside vertically scrollable container. For vertically scrollable container, browser cut/hide content that overlaps horizontally (similar to |
This is still an issue, its sad |
ATM the dropdown recognizes the boundaries of the viewport and positions accordingly:
But it does not recognize the
overflow: hidden
ancestors and gets cut off, which is definitely annoying. It makes it impossible to use dropdown in the toolbar in modal windows if the dropdown is to be somewhere later in the toolbar (closer to the right edge).The text was updated successfully, but these errors were encountered: