Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create basic implementation of sub/sup features #5557

Closed
ma2ciek opened this issue Sep 7, 2018 · 2 comments · Fixed by ckeditor/ckeditor5-basic-styles#80
Closed

Create basic implementation of sub/sup features #5557

ma2ciek opened this issue Sep 7, 2018 · 2 comments · Fixed by ckeditor/ckeditor5-basic-styles#80
Labels
package:basic-styles type:feature This issue reports a feature request (an idea for a new functionality or a missing option).
Milestone
iteration 21

Comments

@ma2ciek
Copy link
Contributor

ma2ciek commented Sep 7, 2018

In contrast to the https://github.com/ckeditor/ckeditor5-basic-styles/issues/75, which defines its advanced usage, edge cases, and semantics, this issue should be used as a base requirement for the ckeditor/ckeditor5-basic-styles#74.

The sub/sup features should:

  • working in base scenarios
  • do not crash the editor
  • have their own buttons, which look can be improved in the future
  • have a manual sample
@joachimdoerr
Copy link

https://github.com/basecondition/ckeditor5-supsub

@Reinmar
Copy link
Member

Reinmar commented Nov 12, 2018

Hi! Thanks for the link. This feature is actually on a review now (ckeditor/ckeditor5-basic-styles#80) and will be a part of the upcoming release.

Reinmar referenced this issue in ckeditor/ckeditor5-basic-styles Nov 13, 2018
@Reinmar
Merge pull request #80 from ckeditor/t/76
f281e99 
Feature: Introduced the `Superscript` and the `Subscript` features. Closes #76. Closes #74.

Thanks to @idleb!
@mlewand mlewand transferred this issue from ckeditor/ckeditor5-basic-styles Oct 9, 2019
@mlewand mlewand added this to the iteration 21 milestone Oct 9, 2019
@mlewand mlewand added type:feature This issue reports a feature request (an idea for a new functionality or a missing option). package:basic-styles labels Oct 9, 2019
@ma2ciek ma2ciek mentioned this issue Oct 11, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
package:basic-styles type:feature This issue reports a feature request (an idea for a new functionality or a missing option).
Projects
None yet
Milestone
iteration 21
Development

Successfully merging a pull request may close this issue.

Introduced the superscript and the subscript features ckeditor/ckeditor5-basic-styles
4 participants
@Reinmar @joachimdoerr @ma2ciek @mlewand