Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Editor should be focusable in read only mode #6080

Closed
scofalik opened this issue Jan 16, 2020 · 1 comment
Closed

Editor should be focusable in read only mode #6080

scofalik opened this issue Jan 16, 2020 · 1 comment
Labels
domain:accessibility This issue reports an accessibility problem. domain:ui/ux This issue reports a problem related to UI or UX. package:engine package:ui resolution:duplicate This issue is a duplicate of another issue and was merged into it. type:improvement This issue reports a possible enhancement of an existing feature.

Comments

@scofalik
Copy link
Contributor

scofalik commented Jan 16, 2020 •
edited
Loading

📝 Provide a description of the improvement

At the moment, when we switch the editor to the read-only mode, the editor cannot be focused anymore. As I wonder about it, it doesn't make much sense. You still can click around (and the selection moves). You can click, for example, on a comment marker to highlight a comment. I think that those two properties - focusing and being editable - should not be connected. They mean different things.

Some features behaviors are based on focusing and blurring the editor so it would be nice to have focus working consistently both in the editing mode and in the read-only mode.

My case is that, in the read-only mode, in comments feature, after fixing some other bugs, I have new problems and correct focus handling might solve them.
@scofalik scofalik added the type:improvement This issue reports a possible enhancement of an existing feature. label Jan 16, 2020
@Reinmar Reinmar added domain:ui/ux This issue reports a problem related to UI or UX. package:engine package:ui domain:accessibility This issue reports an accessibility problem. labels Jan 21, 2020
@Reinmar Reinmar added this to the nice-to-have milestone Jan 21, 2020
@mlewand
Copy link
Contributor

mlewand commented Mar 18, 2020

#6200 is a duplicate of this issue, but since the former has more discussion and a related PR open already I'll close this one.

@mlewand mlewand closed this as completed Mar 18, 2020
@mlewand mlewand added the resolution:duplicate This issue is a duplicate of another issue and was merged into it. label Mar 18, 2020
@Reinmar Reinmar removed this from the nice-to-have milestone Mar 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
domain:accessibility This issue reports an accessibility problem. domain:ui/ux This issue reports a problem related to UI or UX. package:engine package:ui resolution:duplicate This issue is a duplicate of another issue and was merged into it. type:improvement This issue reports a possible enhancement of an existing feature.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@Reinmar @scofalik @mlewand @Mgsy