-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Link Toolbar / Browse Server #6672
Comments
Hi, thanks for the report. CKEditor 5 already implements link balloon which opens when a user sets the selection inside of the link. If you'd like to modify it, I think the best way will be forking the link plugin repository and adjusting the balloon view for your needs. |
Thanks. It seems like a lot of extra work. I'll keep this open as I thik it would make a great feature. |
@nfplee, could you please explain how this link toolbar should work? What problem will be solved by implementing it? And how it would be different from our link balloon? |
@Mgsy. Thanks for replying. With the image plugin I can say the following to add my custom widget (media image) at the end of the image toolbar:
It would be great if we could say the same for a link e.g.:
The reason I'd like this is because I build a CMS and I'd like the users to browse the site hierarchy for a URL. |
Thanks for the details. So, to simplify - you'd like to make the default link balloon configurable, so you can add your custom buttons to it? Actually, currently you can do it on your own, however, it will require changing a code in Link plugin package. All buttons are defined in LinkActionsView, so you can register a new button and add it as a child to the main view. |
Thanks but I'd like to be able to achieve it without hacking the code so my changes are not lost when I upgrade. |
Sure, that's totally understandable. However, please be aware that we can't promise that we'll be able to worki on this feature, as it requires changing the whole implementation of the link balloon and this is the first report about this use case. Our choices for making features bases on community feedback and there are a lot of highly requested features. We'd love to work on every feature reported by our community, but the reality is that our capabilities are limited and we can handle only the most requested ones :( Anyway, let's wait for the feedback and to everyone interested in this feature - feel free to add 👍 to the first post to bump its popularity. |
@Mgsy yeah no probs. It's great that it's been considered at all. Thanks |
There has been no activity on this issue for the past year. We've marked it as stale and will close it in 30 days. We understand it may still be relevant, so if you're interested in the solution, leave a comment or reaction under this issue. |
Please could you keep this open. |
There has been no activity on this issue for the past year. We've marked it as stale and will close it in 30 days. We understand it may still be relevant, so if you're interested in the solution, leave a comment or reaction under this issue. |
This may be addressed by #17230. |
I'm looking for the feature requested by @nfplee, too. We're facing the same issue: migrating from CKEditor 4 to 5 and expecting the same feature for links—being able to browse the server and add a link based on our users' resources. See the image below from CKEditor 4: (Note: This #17230 does not solve our problem.) |
In #17230 instead of the browse server option, there will be a possibility to add one or multiple custom link lists based on your user resources, similar to bookmarks. Sorry, it may not be clear. Would that solve your problem? |
The thing is that, with the "Browse server" option, we have integrated the library "elFinder" to allow our users to link any file they have stored on the server. |
I can see there's an image toolbar which allows me to trigger a custom command to implement a "Browse Server" option similar to CKEditor 4. However there doesn't apear to be the same option for links.
This is abit of a problem for me upgrading an application (which uses CKEditor 4), since I use it for a CMS and I'd like the users to be able to select a URL based on the existing pages of their site.
The text was updated successfully, but these errors were encountered: