Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automated tests – Karma/Webpack watcher runs tests n times #7068

Closed
pomek opened this issue Dec 20, 2017 · 0 comments
Closed

Automated tests – Karma/Webpack watcher runs tests n times #7068

pomek opened this issue Dec 20, 2017 · 0 comments
Assignees
Labels
package:dev type:bug This issue reports a buggy (incorrect) behavior.
Milestone

Comments

@pomek
Copy link
Member

pomek commented Dec 20, 2017

image

Fortunately, this issue was reported here – webpack/watchpack#25.

Fix for the issue is simple. The code below should be added here:

https://github.com/ckeditor/ckeditor5-dev/blob/8feba11aa6908e69141283b2b1fd5e0ea3ff68fe/packages/ckeditor5-dev-tests/lib/tasks/runautomatedtests.js#L91-L92

const now = Date.now() / 1000;
const then = now - 5;
fs.utimesSync( ENTRY_FILE_PATH, then, then );
@pomek pomek self-assigned this Dec 20, 2017
szymonkups referenced this issue in ckeditor/ckeditor5-dev Dec 20, 2017
Fix: Karma will not execute the tests multiple times when works in watch mode. Closes #346.
@mlewand mlewand transferred this issue from ckeditor/ckeditor5-dev May 18, 2020
@mlewand mlewand added this to the iteration 14 milestone May 18, 2020
@mlewand mlewand added type:bug This issue reports a buggy (incorrect) behavior. package:dev labels May 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package:dev type:bug This issue reports a buggy (incorrect) behavior.
Projects
None yet
Development

No branches or pull requests

2 participants