Widget marker conversion handles only classes

[scofalik]

📝 Provide a description of the improvement

When a view element is widgetized, it gets its own handling of markers that are created on that widget. All widgets get that by default. Thanks to that we have borders on images or tables when we add comments or other markers to it.

This is the part of the code that is responsible for that: https://github.com/ckeditor/ckeditor5/blob/master/packages/ckeditor5-widget/src/utils.js#L109-L114

As you can see, this mechanism handles only classes. This is different than handling marker conversion for texts: https://github.com/ckeditor/ckeditor5/blob/master/packages/ckeditor5-engine/src/conversion/downcasthelpers.js#L924

For texts, we create a view attribute element from the descriptor and we wrap the text with it. This is very simple:

ckeditor5/packages/ckeditor5-engine/src/conversion/downcasthelpers.js

Line 423 in 4d2f5f9

export function createViewElementFromHighlightDescriptor( writer, descriptor ) {

As you can see, attributes are handled as well (priority does not make sense for non-attribute view elements).

We add data-comment="" attribute to for comments markers (in editing downcast). I just noticed that it is not set for widgets. We didn't get any issue reports, though.

[scofalik]

I also believe that setHighlightHandling() should have third and fourth parameters be optional. Or I'd introduce setDefaultHighlightHandling() function that would do that. I believe that in a lot of use cases we will use just simple class+attributes conversion.

[CKEditorBot]

There has been no activity on this issue for the past year. We've marked it as stale and will close it in 30 days. We understand it may still be relevant, so if you're interested in the solution, leave a comment or reaction under this issue.

[CKEditorBot]

We've closed your issue due to inactivity over the last year. We understand that the issue may still be relevant. If so, feel free to open a new one (and link this issue to it).