Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Get rid of the ResizeObserver polyfill #7375

Closed
oleq opened this issue Jun 4, 2020 · 4 comments
Closed

Get rid of the ResizeObserver polyfill #7375

oleq opened this issue Jun 4, 2020 · 4 comments
Labels
package:utils resolution:resolved This issue was already resolved (e.g. by another ticket). squad:core Issue to be handled by the Core team. status:stale type:task This issue reports a chore (non-production change) and other types of "todos".

Comments

@oleq
Copy link
Member

oleq commented Jun 4, 2020

Provide a description of the task

We had to use a polyfill because Safari didn't support the native API. Now it looks like all modern browsers support it (learn more) and we might consider getting rid of it, which will simplify the code.

iOS adoption rate is always high so it's a matter of weeks until most of the users have Safari 13.1 in their systems. I thought the Safari on Mac might be a problem but the official release notes say

Safari 13.1 ships with iOS 13.4 and macOS 10.15.4. It’s also available for macOS 10.14.6 and 10.13.6.

So Catalina, Mojave and High Sierra users should also benefit from the new API (provided they update their OSs) and there should be no breaking change for them.

cc @panr
@oleq oleq added type:task This issue reports a chore (non-production change) and other types of "todos". package:utils squad:red labels Jun 4, 2020
@oleq oleq mentioned this issue Jun 4, 2020
Closed
@mlewand mlewand added this to the nice-to-have milestone Jun 29, 2020
@jodator
Copy link
Contributor

jodator commented Jul 28, 2020

Let's wait with this for iOS upgrade to be propagated for most iPhones.

@oleq
Copy link
Member Author

oleq commented Jul 29, 2020

ResizeObserver was introduced in iOS 13.4. It's around 63% of the market as of today.

via https://gs.statcounter.com/ios-version-market-share/mobile-tablet/worldwide/#monthly-202006-202006-bar.

@Reinmar Reinmar removed the squad:red label Nov 2, 2020
@Reinmar Reinmar added squad:core Issue to be handled by the Core team. and removed squad:dx labels Sep 9, 2021
@pomek pomek removed this from the nice-to-have milestone Feb 21, 2022
@CKEditorBot
Copy link
Collaborator

There has been no activity on this issue for the past year. We've marked it as stale and will close it in 30 days. We understand it may still be relevant, so if you're interested in the solution, leave a comment or reaction under this issue.

@oleq
Copy link
Member Author

oleq commented Oct 11, 2023

The polyfill has been removed some time ago.

@oleq oleq closed this as completed Oct 11, 2023
@Witoso Witoso added the resolution:resolved This issue was already resolved (e.g. by another ticket). label Oct 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
package:utils resolution:resolved This issue was already resolved (e.g. by another ticket). squad:core Issue to be handled by the Core team. status:stale type:task This issue reports a chore (non-production change) and other types of "todos".
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
7 participants
@Reinmar @jodator @oleq @pomek @mlewand @Witoso @CKEditorBot