Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove UID from override gravity (two-set caret movement) #7450

Closed
tomalec opened this issue Jun 17, 2020 · 2 comments
Closed

Remove UID from override gravity (two-set caret movement) #7450

tomalec opened this issue Jun 17, 2020 · 2 comments
Labels
domain:dx This issue reports a developer experience problem or possible improvement. package:engine resolution:expired This issue was closed due to lack of feedback. status:stale type:improvement This issue reports a possible enhancement of an existing feature.

Comments

@tomalec
Copy link
Contributor

tomalec commented Jun 17, 2020 •
edited
Loading

📝 Provide a description of the improvement

As we discussed today on F2F with @Reinmar current implementation of per-UID gravity is flawed.
Once we will move 2SCM to a separate plugin, so it would orchestrate behavior for multiple arguments, there will be no need for specific UIDs, as there will be only one place that would use it.

Therefore we could remove the logic for generating UIDs, and document overrideGravity as "internal, use at your own risk".

📃 Other details

  • Browser: …
  • OS: …
  • CKEditor version: …
  • Installed CKEditor plugins: …

Related issues

#1663 (comment)
#7444

If you'd like to see this improvement implemented, add a 👍 reaction to this post.
@tomalec tomalec added type:improvement This issue reports a possible enhancement of an existing feature. squad:red labels Jun 17, 2020
@tomalec tomalec self-assigned this Jun 17, 2020
@tomalec tomalec removed their assignment Jul 20, 2020
@Reinmar Reinmar added this to the backlog milestone Jul 27, 2020
@Reinmar Reinmar added domain:dx This issue reports a developer experience problem or possible improvement. package:engine and removed squad:red labels Jul 27, 2020
@pomek pomek removed this from the backlog milestone Feb 21, 2022
@CKEditorBot
Copy link
Collaborator

There has been no activity on this issue for the past year. We've marked it as stale and will close it in 30 days. We understand it may still be relevant, so if you're interested in the solution, leave a comment or reaction under this issue.

@CKEditorBot
Copy link
Collaborator

We've closed your issue due to inactivity over the last year. We understand that the issue may still be relevant. If so, feel free to open a new one (and link this issue to it).

@CKEditorBot CKEditorBot added the resolution:expired This issue was closed due to lack of feedback. label Nov 13, 2023
@CKEditorBot CKEditorBot closed this as not planned Won't fix, can't repro, duplicate, stale Nov 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
domain:dx This issue reports a developer experience problem or possible improvement. package:engine resolution:expired This issue was closed due to lack of feedback. status:stale type:improvement This issue reports a possible enhancement of an existing feature.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@tomalec @Reinmar @pomek @CKEditorBot