-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
When adding a link to any word in the editor, I cannot ever exit the link unless I press enter (go to new line). Pressing escape, multiple spaces or anything else fail. #7646
Comments
Sorry I forgot to clarify, this happens when doing a custom build https://ckeditor.com/ckeditor-5/online-builder/ |
Hi, I just checked editor from online builder and it works fine for me. Here's a screencast: Please note that to exit the link, you need to use |
We changed this behavior a bit recently. Now, when you click after a link you will be placed outside that link. It already works this way here: https://ckeditor.com/docs/ckeditor5/latest/examples/builds/classic-editor.html. We changed that because we understand that two-step caret movement is a bit confusing to some users. It should now be much easier for them to place the caret outside (as intuitively many will click there and those who use keyboard to navigate have a higher chance to learn about 2-step caret movement). We could also consider adding an option to disable 2-step caret movement via the config but you also gave some interesting idea – pressing Esc could work this way. Do you think that the latter would help? |
@Reinmar clicking away indeed helps, but consider the scenario when the first thing you enter is a link, then there is no way to click outside or do any action unless you press enter (new line). I think you guys should utilize escape key more. i.e for user to close font selector, end link select and many more. esc should exit current toolbar (this is how outlook email/word processor, chrome and everything else works). i.e try to open any menu in chrome and press escape, it will be closed/exited immediately. Anyway for the link itself, I think escape is less confusing (while I believe for best experience the behavior of microsoft word is the best one), once I add a link to "selection" then there is no need to continue editing that selection, it should just exit link mode and let me continue doing what I was doing. |
There has been no activity on this issue for the past year. We've marked it as stale and will close it in 30 days. We understand it may still be relevant, so if you're interested in the solution, leave a comment or reaction under this issue. |
We've closed your issue due to inactivity over the last year. We understand that the issue may still be relevant. If so, feel free to open a new one (and link this issue to it). |
📝 Provide detailed reproduction steps (if any)
Download CKEditor 5 ClassicEditor build and use the sample html file and add link to text, the link doesn't exit unless I press enter.
✔️ Expected result
Link editing should exit on space or exit or both.
❌ Actual result
Link editing is not exiting, below is an example from sample downloaded (same problem on my site):
📃 Other details
Here is gif file to describe the problem. Its super annoying if you are trying to past/insert a link while editing a document and there is no workaround unless you break your flow.
If you'd like to see this fixed sooner, add a 👍 reaction to this post.
The text was updated successfully, but these errors were encountered: