Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When adding a link to any word in the editor, I cannot ever exit the link unless I press enter (go to new line). Pressing escape, multiple spaces or anything else fail. #7646

Closed
kherona opened this issue Jul 19, 2020 · 8 comments
Labels
domain:ui/ux This issue reports a problem related to UI or UX. package:typing resolution:expired This issue was closed due to lack of feedback. status:stale type:improvement This issue reports a possible enhancement of an existing feature.

Comments

@kherona
Copy link

kherona commented Jul 19, 2020

📝 Provide detailed reproduction steps (if any)

Download CKEditor 5 ClassicEditor build and use the sample html file and add link to text, the link doesn't exit unless I press enter.

✔️ Expected result

Link editing should exit on space or exit or both.

❌ Actual result

Link editing is not exiting, below is an example from sample downloaded (same problem on my site):

📃 Other details

Here is gif file to describe the problem. Its super annoying if you are trying to past/insert a link while editing a document and there is no workaround unless you break your flow.

Untitled Project

  • Browser: Tested this on Chrome + Firefox. Same behavior.
  • OS: Windows 10
  • CKEditor version: CKEditor 5 ClassicEditor build (sample html file + my project are affected by this)
  • Installed CKEditor plugins: nothing extra

If you'd like to see this fixed sooner, add a 👍 reaction to this post.

@kherona kherona added the type:bug This issue reports a buggy (incorrect) behavior. label Jul 19, 2020
@kherona
Copy link
Author

kherona commented Jul 19, 2020

Sorry I forgot to clarify, this happens when doing a custom build https://ckeditor.com/ckeditor-5/online-builder/
I downloaded build 20.0.0 from https://ckeditor.com/ckeditor-5/download/ and didn't face the same issue.

@FilipTokarski
Copy link
Member

Hi, I just checked editor from online builder and it works fine for me. Here's a screencast:

20_link_1

Please note that to exit the link, you need to use arrow right or arrow left. Here you can read more about typing around links.

@FilipTokarski FilipTokarski added the pending:feedback This issue is blocked by necessary feedback. label Jul 20, 2020
@kherona
Copy link
Author

kherona commented Jul 20, 2020

Thanks for the update Filip.

I found about this earlier today, I even had to inform my users about this (as it gets super frustrating to exit a link if the user doesn't know about the arrows and I dont expect every user on my platform to read CKEditor docs to work on it).

Below is an example from Word Processor (its almost the standard way of word processing), as you can see, if the user selects a word or group of characters and enters a link, then the link editing mode exits immediately (which makes a lot of sense).
Untitled Project

Is there a way to configure this to exit on specifc key strokes, i.e double space (and there is no characters after), or maybe exit the link mode when pressing escape as I didn't know about the arrows and spent hours trying to figure this out (consider the case when the first word in the text is a link and you want to add more stuff after it without pressing arrow)

@kherona
Copy link
Author

kherona commented Jul 20, 2020

I had to put this after a few users said that links had problem, they couldn't explain the problem, however I believe its due to this.

Now I have to keep this message as there is no way to exit link mode (maybe we can have an icon/button to exit editing as well?)
image

@Reinmar
Copy link
Member

Reinmar commented Jul 20, 2020

We changed this behavior a bit recently. Now, when you click after a link you will be placed outside that link. It already works this way here: https://ckeditor.com/docs/ckeditor5/latest/examples/builds/classic-editor.html.

We changed that because we understand that two-step caret movement is a bit confusing to some users. It should now be much easier for them to place the caret outside (as intuitively many will click there and those who use keyboard to navigate have a higher chance to learn about 2-step caret movement).

We could also consider adding an option to disable 2-step caret movement via the config but you also gave some interesting idea – pressing Esc could work this way. Do you think that the latter would help?

@Reinmar Reinmar added domain:ui/ux This issue reports a problem related to UI or UX. package:typing type:improvement This issue reports a possible enhancement of an existing feature. and removed type:bug This issue reports a buggy (incorrect) behavior. labels Jul 20, 2020
@Reinmar Reinmar added this to the nice-to-have milestone Jul 20, 2020
@kherona
Copy link
Author

kherona commented Jul 20, 2020

@Reinmar clicking away indeed helps, but consider the scenario when the first thing you enter is a link, then there is no way to click outside or do any action unless you press enter (new line).

I think you guys should utilize escape key more. i.e for user to close font selector, end link select and many more. esc should exit current toolbar (this is how outlook email/word processor, chrome and everything else works). i.e try to open any menu in chrome and press escape, it will be closed/exited immediately.

Anyway for the link itself, I think escape is less confusing (while I believe for best experience the behavior of microsoft word is the best one), once I add a link to "selection" then there is no need to continue editing that selection, it should just exit link mode and let me continue doing what I was doing.

@FilipTokarski FilipTokarski removed the pending:feedback This issue is blocked by necessary feedback. label Jul 20, 2020
@jodator jodator added the squad:core Issue to be handled by the Core team. label Jul 28, 2020
@Reinmar Reinmar removed the squad:core Issue to be handled by the Core team. label Oct 16, 2020
@pomek pomek removed this from the nice-to-have milestone Feb 21, 2022
@CKEditorBot
Copy link
Collaborator

There has been no activity on this issue for the past year. We've marked it as stale and will close it in 30 days. We understand it may still be relevant, so if you're interested in the solution, leave a comment or reaction under this issue.

@CKEditorBot
Copy link
Collaborator

We've closed your issue due to inactivity over the last year. We understand that the issue may still be relevant. If so, feel free to open a new one (and link this issue to it).

@CKEditorBot CKEditorBot added the resolution:expired This issue was closed due to lack of feedback. label Nov 13, 2023
@CKEditorBot CKEditorBot closed this as not planned Won't fix, can't repro, duplicate, stale Nov 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
domain:ui/ux This issue reports a problem related to UI or UX. package:typing resolution:expired This issue was closed due to lack of feedback. status:stale type:improvement This issue reports a possible enhancement of an existing feature.
Projects
None yet
Development

No branches or pull requests

6 participants