Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Are 2SCM attributes a new kind of attributes? #7677

Closed
jodator opened this issue Jul 23, 2020 · 3 comments
Closed

Are 2SCM attributes a new kind of attributes? #7677

jodator opened this issue Jul 23, 2020 · 3 comments
Labels
package:basic-styles package:engine package:link resolution:expired This issue was closed due to lack of feedback. status:discussion status:stale type:feature This issue reports a feature request (an idea for a new functionality or a missing option).

Comments

@jodator
Copy link
Contributor

jodator commented Jul 23, 2020

After working with @pomek on various improvements on typing around link I came to a conclusion that code could (should) behave the same way as link:

ATM we have only two 2SCM features that could potentially behave in a similar fashion. As @pomek noticed we fix how text attributes interact with selection for link:

  • we want to type with bold but not with link, 
  • we have 2SCM for link not bold,
  • etc

To make link act differently then bold we introduced "hacks" or overrides to a default editor behavior. Which is fine for one feature. However, if we decide that code should behave the same way as link then I think that we might introduce a "non-sticky" attribute.

I don't have a valid RFC for this - so this is an invitation to discuss some things first.

  • do we want to code behave the same way as linkHref
  • do we see then a need for a new attribute's property?

If you'd like to see this feature implemented, add a 👍 reaction to this post.

@jodator jodator added status:discussion type:feature This issue reports a feature request (an idea for a new functionality or a missing option). package:basic-styles package:engine package:link labels Jul 23, 2020
@Reinmar
Copy link
Member

Reinmar commented Jul 23, 2020

  • do we want to code behave the same way as linkHref

I started wondering about this as well recently. And I don't have an opinion here yet. Let's use this for a while in GitHub Writer.

Potentially. I don't know how hacky the implementation is in the end and whether it can be actually simplified if that landed in the engine.

@Reinmar Reinmar added this to the backlog milestone Jul 23, 2020
@pomek pomek removed this from the backlog milestone Feb 21, 2022
@CKEditorBot
Copy link
Collaborator

There has been no activity on this issue for the past year. We've marked it as stale and will close it in 30 days. We understand it may still be relevant, so if you're interested in the solution, leave a comment or reaction under this issue.

@CKEditorBot
Copy link
Collaborator

We've closed your issue due to inactivity over the last year. We understand that the issue may still be relevant. If so, feel free to open a new one (and link this issue to it).

@CKEditorBot CKEditorBot added the resolution:expired This issue was closed due to lack of feedback. label Nov 13, 2023
@CKEditorBot CKEditorBot closed this as not planned Won't fix, can't repro, duplicate, stale Nov 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package:basic-styles package:engine package:link resolution:expired This issue was closed due to lack of feedback. status:discussion status:stale type:feature This issue reports a feature request (an idea for a new functionality or a missing option).
Projects
None yet
Development

No branches or pull requests

4 participants