Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document text part language feature #9211

Closed
jacekbogdanski opened this issue Mar 11, 2021 · 2 comments · Fixed by #9301
Closed

Document text part language feature #9211

jacekbogdanski opened this issue Mar 11, 2021 · 2 comments · Fixed by #9301
Assignees
Labels
domain:v4-compatibility This issue reports a CKEditor 4 feature/option that's missing in CKEditor 5. type:docs This issue reports a task related to documentation (e.g. an idea for a guide).

Comments

@jacekbogdanski
Copy link
Member

jacekbogdanski commented Mar 11, 2021

📝 Provide a description of requested docs changes

Followup ticket for text part feature documentation - #9074

@jacekbogdanski jacekbogdanski added type:docs This issue reports a task related to documentation (e.g. an idea for a guide). squad:compat domain:v4-compatibility This issue reports a CKEditor 4 feature/option that's missing in CKEditor 5. labels Mar 11, 2021
@jacekbogdanski jacekbogdanski added this to the iteration 41 milestone Mar 11, 2021
@jacekbogdanski jacekbogdanski changed the title Document text fragment language feature Document text part language feature Mar 17, 2021
@jacekbogdanski
Copy link
Member Author

jacekbogdanski commented Mar 17, 2021

Since we already have UI Language feature entry, I'm wondering where should be put new documentation for text part language (which is being a part of the language package).

I worry that an additional Langauge entry to already existing UI Language could be misleading. On the other side, the feature is not really related to the editor UI anyhow, so adding docs on top of UI Language also doesn't seem like a good idea. Maybe we could add an additional group for the existing UI Langauge and text part language feature? Something like:

  • Language
    • UI Language
    • Multilingual Content

However, it would break the ckeditor5/latest/features/ui-language.html link on the latest version which may not be what we want. Any thoughts on that @AnnaTomanek, @Reinmar, @Mgsy?

We have UI Language entry, not a category ;)

Right, updated.

@godai78
Copy link
Contributor

godai78 commented Mar 17, 2021

We have UI Language entry, not a category ;)

Getting this together seems like a good idea at first, but won't we cause confusion? We already need to underline this feature got nothing to do with the UI language, so that becomes slippery.

Feature-wise and application oriented, this would also make sense to have it grouped with spellcheck rather, than UI.

Broken links is something we can deal with by relinking, so this would be least concern.

EDIT: cause it may not be clear - I treat UI language as all toolbar & stuff things, while content language is another matter.

Now, seeing the guide linked also deals with RTL languages, we may consider splitting it (separating the content language from interface language) and getting this split part together with the new feature.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
domain:v4-compatibility This issue reports a CKEditor 4 feature/option that's missing in CKEditor 5. type:docs This issue reports a task related to documentation (e.g. an idea for a guide).
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants