Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docs: related block; new demos; minor fixes and expansions #8250

Merged
merged 24 commits into from
Oct 14, 2020
Merged

Docs: related block; new demos; minor fixes and expansions #8250

merged 24 commits into from
Oct 14, 2020

Conversation

godai78
Copy link
Contributor

@godai78 godai78 commented Oct 13, 2020 •
edited
Loading

Closes: cksource/content-documentation-proofread#335
Closes: cksource/content-documentation-proofread#336

Adding "Related features" section to selected CKEditor 5 features documentation. Updating demos. Fixes.

@godai78 godai78 requested a review from AnnaTomanek October 13, 2020 07:35
AnnaTomanek
AnnaTomanek suggested changes Oct 13, 2020
View reviewed changes
Copy link
Contributor

@AnnaTomanek AnnaTomanek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some comments inside. Make sure you port the changed fragments to all occurrences, I just flagged the first one.

packages/ckeditor5-alignment/docs/features/text-alignment.md Outdated Show resolved Hide resolved
packages/ckeditor5-alignment/docs/features/text-alignment.md Outdated Show resolved Hide resolved
packages/ckeditor5-alignment/docs/features/text-alignment.md Outdated Show resolved Hide resolved
packages/ckeditor5-alignment/docs/features/text-alignment.md Show resolved Hide resolved
packages/ckeditor5-basic-styles/docs/features/basic-styles.md Outdated Show resolved Hide resolved
packages/ckeditor5-heading/docs/features/title.md Show resolved Hide resolved
packages/ckeditor5-highlight/docs/features/highlight.md Show resolved Hide resolved
packages/ckeditor5-list/docs/features/lists.md Outdated Show resolved Hide resolved
packages/ckeditor5-list/docs/features/lists.md Outdated Show resolved Hide resolved
packages/ckeditor5-remove-format/docs/features/remove-format.md Show resolved Hide resolved
@godai78 godai78 changed the title Docs basicstyles related Docs: related block; new demos; minor fixes and expansions Oct 13, 2020
AnnaTomanek
AnnaTomanek suggested changes Oct 14, 2020
View reviewed changes
Copy link
Contributor

@AnnaTomanek AnnaTomanek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another batch of comments. I love the new demo content! 😍

packages/ckeditor5-alignment/docs/features/text-alignment.md Outdated Show resolved Hide resolved
packages/ckeditor5-alignment/docs/features/text-alignment.md Show resolved Hide resolved
packages/ckeditor5-alignment/docs/features/text-alignment.md Outdated Show resolved Hide resolved
packages/ckeditor5-basic-styles/docs/features/basic-styles.md Outdated Show resolved Hide resolved
packages/ckeditor5-basic-styles/docs/features/basic-styles.md Outdated Show resolved Hide resolved
packages/ckeditor5-indent/docs/features/indent.md Outdated Show resolved Hide resolved
packages/ckeditor5-list/docs/features/lists.md Outdated Show resolved Hide resolved
packages/ckeditor5-remove-format/docs/features/remove-format.md Outdated Show resolved Hide resolved
packages/ckeditor5-remove-format/docs/features/remove-format.md Outdated Show resolved Hide resolved
packages/ckeditor5-remove-format/docs/features/remove-format.md Show resolved Hide resolved
godai78 and others added 8 commits October 14, 2020 10:34
@godai78 @AnnaTomanek
Update packages/ckeditor5-alignment/docs/features/text-alignment.md
c1e6d96 
Co-authored-by: Anna Tomanek <a.tomanek@cksource.com>
@godai78 @AnnaTomanek
Update packages/ckeditor5-basic-styles/docs/features/basic-styles.md
4a008da 
Co-authored-by: Anna Tomanek <a.tomanek@cksource.com>
@godai78 @AnnaTomanek
Update packages/ckeditor5-basic-styles/docs/features/basic-styles.md
e6f3e5a 
Co-authored-by: Anna Tomanek <a.tomanek@cksource.com>
@godai78 @AnnaTomanek
Update packages/ckeditor5-font/docs/features/font.md
12bf6c1 
Co-authored-by: Anna Tomanek <a.tomanek@cksource.com>
@godai78 @AnnaTomanek
Update packages/ckeditor5-heading/docs/features/title.md
736b3ba 
Co-authored-by: Anna Tomanek <a.tomanek@cksource.com>
@godai78 @AnnaTomanek
Update packages/ckeditor5-heading/docs/features/title.md
e09a0d3 
Co-authored-by: Anna Tomanek <a.tomanek@cksource.com>
@godai78
Docs: related features tier 3. [skip ci]
6f7eb58
@godai78
Docs: related features tier 3.5. [skip ci]
4b79f5b
@godai78 @AnnaTomanek
Update packages/ckeditor5-indent/docs/features/indent.md
d6601b3 
Co-authored-by: Anna Tomanek <a.tomanek@cksource.com>
AnnaTomanek
AnnaTomanek reviewed Oct 14, 2020
View reviewed changes
docs/index.md Outdated Show resolved Hide resolved
@godai78 @AnnaTomanek
True, true.
531999f 
Co-authored-by: Anna Tomanek <a.tomanek@cksource.com>
AnnaTomanek
AnnaTomanek approved these changes Oct 14, 2020
View reviewed changes
Copy link
Contributor

@AnnaTomanek AnnaTomanek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks! I especially like the updated demo content 😍 .

@AnnaTomanek AnnaTomanek merged commit e25dc0a into stable Oct 14, 2020
@AnnaTomanek AnnaTomanek deleted the docs-basicstyles-related branch October 14, 2020 10:45
@godai78 godai78 mentioned this pull request Oct 30, 2020
Closed
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AnnaTomanek AnnaTomanek AnnaTomanek approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@godai78 @AnnaTomanek