Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs pastefromoffice demo #8349

Closed
wants to merge 10 commits into from
Closed

Docs pastefromoffice demo #8349

wants to merge 10 commits into from

Conversation

godai78
Copy link
Contributor

@godai78 godai78 commented Oct 27, 2020

New demos for Paste from Word and Paste from Google Docs guides:

  • list styles added to the editor,
  • new placeholder texts to make the demos look more human-appealing (See: #6268).

@godai78
Copy link
Contributor Author

godai78 commented Nov 3, 2020

This should ONLY be merged after #8316 is merged, otherwise it will generate errors.

@AnnaTomanek
Copy link
Contributor

This should ONLY be merged after #8316 is merged, otherwise it will generate errors.

This is only because the approach that you chose here is wrong.

PRs should be atomic and as independent of one another as possible. This means that if you are adding a new guide, and you want to link to it from other guides, you should add these new links in the same PR that introduces the guide. Otherwise you have no way of really testing it, the CI fails and you create an unnecessary dependency that can be easily avoided.

Also, HTML embed is not a feature that is related to the "pasting" category guides, and especially not with paste from Office features. Paste from Office stuff is intended to be used with business documents and in a corporate environment. HTML embed is an experimental feature for advanced developers/webmasters and should not really be advertised in the business/document setting.

@godai78
Copy link
Contributor Author

godai78 commented Nov 3, 2020

OK. I will remove it again and add it again once you merge the plain text guide :)

@godai78
Copy link
Contributor Author

godai78 commented Nov 3, 2020

As promised.

@AnnaTomanek
Copy link
Contributor

It looks like there is some workflow misunderstanding here.

The links to the paste plain text guide should NOT be a part of this PR. At all. They should be transparent to this PR because they should be added as part of the PR creating the paste plain text feature, and then merged to stable. As a result, when this PR (#8349) gets merged into stable, they will simply be there, period. No additional thing is needed to be done.

If you need these changes sooner (for example, when you see a conflict with the stable branch because you changed the same section and GitHub is unable to merge it automatically, you can merge stable into this PR first.

@godai78
Copy link
Contributor Author

godai78 commented Nov 3, 2020

I got lost. I don't even remember what was added where. Lest just revert the last commit, merge it and once everything is finally in stable I'll just create a new branch and add it.

@AnnaTomanek
Copy link
Contributor

We have decided to change the approach. Another PR will replace this one.

@AnnaTomanek AnnaTomanek closed this Nov 3, 2020
@AnnaTomanek AnnaTomanek deleted the docs-pastefromoffice-demo branch November 3, 2020 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants