Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pasted URL getting changed when post is submitted #93

Closed
AnnaTomanek opened this issue Mar 5, 2020 · 4 comments
Closed

Pasted URL getting changed when post is submitted #93

AnnaTomanek opened this issue Mar 5, 2020 · 4 comments
Labels
bug Something isn't working upstream Dependent/related to external issues

Comments

@AnnaTomanek
Copy link
Contributor

Pasted URL: https://ckeditor.com/docs/ckeditor4/latest/guide/dev_integration.html becomes https://ckeditor.com/docs/ckeditor4/latest/guide/dev\_integration.html

@AnnaTomanek
Copy link
Contributor Author

Another one: https://docs.google.com/document/d/1JXHcGjpCnAMJk2w2a_FwfqA0w5rbgdcL-Eu_3_zKTtk/edit#heading=h.k1drv7mozlsw got transformed to https://docs.google.com/document/d/1JXHcGjpCnAMJk2w2a\_FwfqA0w5rbgdcL-Eu\_3\_zKTtk/edit#

@fredck
Copy link
Contributor

fredck commented Mar 6, 2020

This affects emojis as well. For example, the :full_moon: emoji is saved as :full\_moon:. But for emojis, GitHub doesn't make a problem, while the same is not true for urls.

The fact is that this is a GitHub bug 😱 (maybe by design?)

The backslash is used to escape characters in markdown. In the issue reported, the underscore is being escaped, because it is the markup for italic.

@fredck fredck added bug Something isn't working upstream Dependent/related to external issues labels Mar 6, 2020
@fredck
Copy link
Contributor

fredck commented Mar 6, 2020

Upstream issue:
domchristie/turndown-plugin-gfm#22

@fredck
Copy link
Contributor

fredck commented Mar 9, 2020

Fix merged into ckeditor/ckeditor5-markdown-gfm#29 with add4f7.

@fredck fredck closed this as completed Mar 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working upstream Dependent/related to external issues
Projects
None yet
Development

No branches or pull requests

2 participants